From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E197A2EDB for ; Mon, 30 Sep 2019 17:28:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD9AE1BEDD; Mon, 30 Sep 2019 17:27:41 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id E6CA11BEAD for ; Mon, 30 Sep 2019 17:27:34 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id y22so5822144pfr.3 for ; Mon, 30 Sep 2019 08:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=00Vzr/C5heiPvoqwsahNL1dLUjUkGiVfyZ2wgTuDXzo=; b=QWBm9L/ez/fCcMI2VDE8mdR09PUbtEfmyvAdl+gadccfun6RdBXNdgwnDzpqYvSH4X rcWer+xgjx1/Umj5jCGRBkGl0DzKeYKf+NJcsDXLr1AEhAgutUVbIaHcT/sh4WGuO/Qs v5TpAxZwEdIwMDbaCv7RnK9SqtgGv6pxND+7ffT2swn1YjX0lNZk7zHxUqMmgrSWpeYO j3c9moT0VKr/J0Q0vAhlNp9Qqf38SDpaT/Zyc86SKwirgaVVesDtAxZvrdK3+ZgJM1CC 43tZVXX7+ARwWf3NVzlYNuidexb0HBedK3I5rKutNAiKXDo89CKFvuST0QvQ/AVqyj1t EmfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=00Vzr/C5heiPvoqwsahNL1dLUjUkGiVfyZ2wgTuDXzo=; b=Raq/5rrJdaVABQLgfQzVGcQ0ojgXscnJrMGyxWNZy8rXvwEL9cF9FKfxX/oCgwcRlF 2vgaCUrNTEeRYlDkczpj7Df6T/oP/iJKDoLS+zGxmE+d2FaTVzIdUpXvnVdH3kvpAXYx Gkk0QXca3rKN3IT+jmYhPGOQakvlhdPwi9/+xjyFe5aNh/KMjZ2GDcWwByhw6V96dH7z nAe0n8a+LnQRXfE7kJZrZUlPJJxu6m9Z1FmTwTQZits2gQEtQdG2J3+LiXW6ffxCdpzD Z4Q0IIxshfXBpbLEPjz+3CyFubJpbywlyqxKWdvz+qrlTOW1iFe4p+Yv3wTNiCIta8pi 34GQ== X-Gm-Message-State: APjAAAV2duovrLoJWXCaYTVKcLnS8gATFHF4fjuuazcr/UeQAaT73sGm 8j6fp+OQGgNOcHzK7OzjGR127sbWtdg= X-Google-Smtp-Source: APXvYqw0Ww2PS22eYiIwf/xbUWyOIjJzP5BIm2KpMewpd5eTdb3wzXadc3FPjGglcDcU5nqtLoT5RA== X-Received: by 2002:a17:90b:903:: with SMTP id bo3mr27236045pjb.52.1569857253481; Mon, 30 Sep 2019 08:27:33 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w14sm30521021pge.56.2019.09.30.08.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 08:27:32 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 30 Sep 2019 08:27:19 -0700 Message-Id: <20190930152721.8029-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190930152721.8029-1-stephen@networkplumber.org> References: <20190928003758.18489-1-stephen@networkplumber.org> <20190930152721.8029-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 4/6] mbuf: add a pktmbuf copy routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This is a commonly used operation that surprisingly the DPDK has not supported. The new rte_pktmbuf_copy does a deep copy of packet. This is a complete copy including meta-data. It handles the case where the source mbuf comes from a pool with larger data area than the destination pool. The routine also has options for skipping data, or truncating at a fixed length. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 70 ++++++++++++++++++++++++++++ lib/librte_mbuf/rte_mbuf.h | 26 +++++++++++ lib/librte_mbuf/rte_mbuf_version.map | 1 + 3 files changed, 97 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c index 12d0258a120d..6888d6bd5dfc 100644 --- a/lib/librte_mbuf/rte_mbuf.c +++ b/lib/librte_mbuf/rte_mbuf.c @@ -324,6 +324,76 @@ rte_pktmbuf_linearize(struct rte_mbuf *mbuf) return 0; } +/* Create a deep copy of mbuf */ +struct rte_mbuf * +rte_pktmbuf_copy(const struct rte_mbuf *m, struct rte_mempool *mp, + uint32_t off, uint32_t len) +{ + const struct rte_mbuf *seg = m; + struct rte_mbuf *mc, *m_last, **prev; + + if (unlikely(off >= m->pkt_len)) + return NULL; + + mc = rte_pktmbuf_alloc(mp); + if (unlikely(mc == NULL)) + return NULL; + + if (len > m->pkt_len - off) + len = m->pkt_len - off; + + /* clone meta data from original */ + mc->port = m->port; + mc->vlan_tci = m->vlan_tci; + mc->vlan_tci_outer = m->vlan_tci_outer; + mc->tx_offload = m->tx_offload; + mc->hash = m->hash; + mc->packet_type = m->packet_type; + mc->timestamp = m->timestamp; + + prev = &mc->next; + m_last = mc; + while (len > 0) { + uint32_t copy_len; + + while (off >= seg->data_len) { + off -= seg->data_len; + seg = seg->next; + } + + /* current buffer is full, chain a new one */ + if (rte_pktmbuf_tailroom(m_last) == 0) { + m_last = rte_pktmbuf_alloc(mp); + if (unlikely(m_last == NULL)) { + rte_pktmbuf_free(mc); + return NULL; + } + ++mc->nb_segs; + *prev = m_last; + prev = &m_last->next; + } + + copy_len = RTE_MIN(seg->data_len - off, len); + if (copy_len > rte_pktmbuf_tailroom(m_last)) + copy_len = rte_pktmbuf_tailroom(m_last); + + /* append from seg to m_last */ + rte_memcpy(rte_pktmbuf_mtod_offset(m_last, char *, + m_last->data_len), + rte_pktmbuf_mtod_offset(seg, char *, + off), + copy_len); + + m_last->data_len += copy_len; + mc->pkt_len += copy_len; + off += copy_len; + len -= copy_len; + } + + __rte_mbuf_sanity_check(mc, 1); + return mc; +} + /* dump a mbuf on console */ void rte_pktmbuf_dump(FILE *f, const struct rte_mbuf *m, unsigned dump_len) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index a6e78e4ea7a6..77266a07c75b 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1927,6 +1927,32 @@ static inline void rte_pktmbuf_free(struct rte_mbuf *m) struct rte_mbuf * rte_pktmbuf_clone(struct rte_mbuf *md, struct rte_mempool *mp); +/** + * Creates a full copy of a given packet mbuf. + * + * Copies all the data from a given packet mbuf to a newly allocated + * set of mbufs. + * + * @param m + * The packet mbuf to be cloned. + * @param mp + * The mempool from which the "clone" mbufs are allocated. + * @param offset + * The number of bytes to skip before copying. + * If the mbuf does not have that many bytes, it is an error + * and NULL is returned. + * @param length + * The upper limit on bytes to copy. Passing UINT32_MAX + * means all data (after offset). + * @return + * - The pointer to the new "clone" mbuf on success. + * - NULL if allocation fails. + */ +__rte_experimental +struct rte_mbuf * +rte_pktmbuf_copy(const struct rte_mbuf *m, struct rte_mempool *mp, + uint32_t offset, uint32_t length); + /** * Adds given value to the refcnt of all packet mbuf segments. * diff --git a/lib/librte_mbuf/rte_mbuf_version.map b/lib/librte_mbuf/rte_mbuf_version.map index aeec3f90f3fe..f471bbcaa2df 100644 --- a/lib/librte_mbuf/rte_mbuf_version.map +++ b/lib/librte_mbuf/rte_mbuf_version.map @@ -57,4 +57,5 @@ EXPERIMENTAL { global: rte_mbuf_check; + rte_pktmbuf_copy; } DPDK_18.08; -- 2.20.1