From: Stephen Hemminger <stephen@networkplumber.org>
To: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Cc: dev@dpdk.org, matan@mellanox.com, rasland@mellanox.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma
Date: Tue, 1 Oct 2019 07:54:29 -0700 [thread overview]
Message-ID: <20191001075429.70a08442@hermes.lan> (raw)
In-Reply-To: <1569928223-6600-1-git-send-email-viacheslavo@mellanox.com>
On Tue, 1 Oct 2019 11:10:23 +0000
Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 40600)
> +#pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wformat-nonliteral"
> +#endif
> + /* Use safe format to check maximal buffer length. */
> while (fscanf(file, format, ifname) == 1) {
> -#pragma GCC diagnostic error "-Wformat-nonliteral"
> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 40600)
> +#pragma GCC diagnostic pop
> +#endif
This is messy, is there not a better way to do this?
next prev parent reply other threads:[~2019-10-01 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 11:10 Viacheslav Ovsiienko
2019-10-01 14:54 ` Stephen Hemminger [this message]
2019-10-01 17:15 ` Slava Ovsiienko
2019-10-01 23:41 ` Stephen Hemminger
2019-10-02 6:15 ` Slava Ovsiienko
2019-10-02 6:55 ` Slava Ovsiienko
2019-10-02 11:54 ` Ferruh Yigit
2019-10-02 12:40 ` Slava Ovsiienko
2019-10-02 6:08 ` [dpdk-dev] [PATCH v2] " Viacheslav Ovsiienko
2019-10-02 12:36 ` [dpdk-dev] [PATCH v3] " Viacheslav Ovsiienko
2019-10-02 16:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001075429.70a08442@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).