From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00320A2EDB for ; Tue, 1 Oct 2019 16:54:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4ABF1BE97; Tue, 1 Oct 2019 16:54:40 +0200 (CEST) Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 7EA561BE93 for ; Tue, 1 Oct 2019 16:54:38 +0200 (CEST) Received: by mail-pf1-f194.google.com with SMTP id y22so8192011pfr.3 for ; Tue, 01 Oct 2019 07:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H/N2qDqbNCuHyvkBF1dB7Gr0sZBRRHJFuYuTWZW1RxE=; b=K0Ay5grBPTZ1q5i/UDcmxkCVyAulyz20pxaoUVWWzupbfu2SjoFudIUjt4uIK89MVS xtosBD2wejxUm9Rb3fWgIpXhoiiWJrXHoBL0/e/bVD/0D08q2S79Umk2SRKHnZ5h7TYO ncuurrl1i9KBiMfv5YYNGlqszY44OyWNt71j1sY1TwzMo+9wahtkkLKc4cS/H6+Iy19l dmIqXMC61egzIUkq5v9ryULBFKxTgVDEOGTw9oW1nyOHblsl+JW3ZojC5l4kSQGDJff2 DkgRtEIoC5YX+fnXjyCKVPnvZR8PFcOpNdz2t7/zNzP59w93b9gyLk2BWb/pgFt+rIwA 3SqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H/N2qDqbNCuHyvkBF1dB7Gr0sZBRRHJFuYuTWZW1RxE=; b=VS4w86zJwGfcdZXy9gFt4zGKq8ZBSf/5ZBg7DFlBFpMrLsAOQjcAxHD2GA8g260NQl /BOwaVKefuTuTSmLjjxaSfDJ7z3O79TEHi7N7UvYBVczpm+vQ8t93q8L50UN6++ozuMy yhmGmEmkizyQ2ho3IC4aWlOP4QJTBrjYAReg5xu5s7CMu9LG0Xm7yfruNO7aLCsLPvkd ZrIhCTDQBbwUa0CS67FtxvWU+QkrzmNIAOdCfjEq5IkwCN8f32Y/5Gw/cDw6dPYu8M/o pNPlrIzolV2AJyFeRKbrQk77Du/Ls6nRhk3GKl3antwRpshtiPTfSRGP/XJ0s4/lghAE EmSA== X-Gm-Message-State: APjAAAXBPwY9ZniIF6BEa1FWvX0xqxIEYZWv5J2uD5gZ5z3G01OeZ8Ja w5yeh/EDWMfxwtJQ+/loCJKqva6seGqS0w== X-Google-Smtp-Source: APXvYqx0lMYo2uAnExFaAB4gZ+oRTypOPbY+y+2woDcNuVrcVo7FMdmhyeWB1NT6d3y6lGB2f9igfw== X-Received: by 2002:a62:1d93:: with SMTP id d141mr28365188pfd.127.1569941677521; Tue, 01 Oct 2019 07:54:37 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y138sm18155450pfb.174.2019.10.01.07.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 07:54:37 -0700 (PDT) Date: Tue, 1 Oct 2019 07:54:29 -0700 From: Stephen Hemminger To: Viacheslav Ovsiienko Cc: dev@dpdk.org, matan@mellanox.com, rasland@mellanox.com, ferruh.yigit@intel.com Message-ID: <20191001075429.70a08442@hermes.lan> In-Reply-To: <1569928223-6600-1-git-send-email-viacheslavo@mellanox.com> References: <1569928223-6600-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation issue with gcc pragma X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 1 Oct 2019 11:10:23 +0000 Viacheslav Ovsiienko wrote: > +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 40600) > +#pragma GCC diagnostic push > #pragma GCC diagnostic ignored "-Wformat-nonliteral" > +#endif > + /* Use safe format to check maximal buffer length. */ > while (fscanf(file, format, ifname) == 1) { > -#pragma GCC diagnostic error "-Wformat-nonliteral" > +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 40600) > +#pragma GCC diagnostic pop > +#endif This is messy, is there not a better way to do this?