From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E467A2F18 for ; Thu, 3 Oct 2019 10:29:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A6251C013; Thu, 3 Oct 2019 10:29:01 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 021341C00E; Thu, 3 Oct 2019 10:28:59 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 01:28:58 -0700 X-IronPort-AV: E=Sophos;i="5.67,251,1566889200"; d="scan'208";a="196277929" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 01:28:55 -0700 Date: Thu, 3 Oct 2019 09:28:52 +0100 From: Bruce Richardson To: Kevin Traynor Cc: dev@dpdk.org, Shreyansh Jain , Alejandro Lucero , Anatoly Burakov , stable@dpdk.org, Maxime Coquelin , Zhihong Wang , Luca Boccassi , Zhang XuemingX Message-ID: <20191003082852.GA1797@bricha3-MOBL.ger.corp.intel.com> References: <20190527161509.50252-1-bruce.richardson@intel.com> <20190528110748.10772-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 0/5] fix 32-bit meson builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 02, 2019 at 04:11:56PM +0100, Kevin Traynor wrote: > On 28/05/2019 12:07, Bruce Richardson wrote: > > This set fixes some issues seen on the automated CI system with building > > on 32-bit Linux distro's using meson and ninja. The fixes are to disable > > unsupported parts of the build, and switch the 32-bit builds to always > > having large file support, so that make and meson are consistent in that > > regard. > > > > V2: add two additional patches to fix clang builds. This allows the > > test-meson-builds.sh script to run successfully on 32-bit Ubuntu > > 16.04 systems. > > > > Bruce Richardson (5): > > net/nfp: disable nfp for 32-bit meson builds > > build: enable large file support on 32-bit > > build: remove unnecessary large file support defines > > eal: mark unused function in 32-bit builds > > build: add libatomic dependency for 32-bit clang compile > > > > Hi Bruce, Intel validation team reported failures with some 32-bit > builds with meson on 18.11.3-rc1. I've tested with these patches and it > fixes the problems. > > I also took d23e141ffa52 ("build: set RTE_ARCH_64 based on pointer > size"), to avoid rebasing the other patches to check 'void *' size > multiple times. > > Any objection to applying for 18.11 branch? > > Kevin. > Nope, no objections. Thanks.