DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/bnxt: fix a check in rxq start op
@ 2019-10-07 19:41 Ajit Khaparde
  2019-10-08  9:54 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2019-10-07 19:41 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, Kalesh AP

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

This patch fixes a wrong check in rxq start operation.
Driver should check for rxq start state.

Fixes: 4316e043cbcb ("net/bnxt: fix RxQ stop/start handling")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c
index a6e0915e2d..d31e4f3964 100644
--- a/drivers/net/bnxt/bnxt_ring.c
+++ b/drivers/net/bnxt/bnxt_ring.c
@@ -612,7 +612,7 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index)
 	if (rc)
 		goto err_out;
 
-	if (!rxq->rx_started) {
+	if (rxq->rx_started) {
 		if (bnxt_init_one_rx_ring(rxq)) {
 			RTE_LOG(ERR, PMD,
 				"bnxt_init_one_rx_ring failed!\n");
-- 
2.20.1 (Apple Git-117)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/bnxt: fix a check in rxq start op
  2019-10-07 19:41 [dpdk-dev] [PATCH] net/bnxt: fix a check in rxq start op Ajit Khaparde
@ 2019-10-08  9:54 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2019-10-08  9:54 UTC (permalink / raw)
  To: Ajit Khaparde, dev; +Cc: Kalesh AP

On 10/7/2019 8:41 PM, Ajit Khaparde wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> This patch fixes a wrong check in rxq start operation.
> Driver should check for rxq start state.
> 
> Fixes: 4316e043cbcb ("net/bnxt: fix RxQ stop/start handling")
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Squashed into relevant commit in next-net, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-08  9:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 19:41 [dpdk-dev] [PATCH] net/bnxt: fix a check in rxq start op Ajit Khaparde
2019-10-08  9:54 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).