From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 245DBA2F6B for ; Tue, 8 Oct 2019 07:49:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B692F1BFFB; Tue, 8 Oct 2019 07:49:52 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 404BB1BFE7; Tue, 8 Oct 2019 07:49:51 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Oct 2019 22:49:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,269,1566889200"; d="scan'208";a="187202051" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga008.jf.intel.com with ESMTP; 07 Oct 2019 22:49:48 -0700 Date: Tue, 8 Oct 2019 13:46:51 +0800 From: Tiwei Bie To: Andrew Rybchenko Cc: Maxime Coquelin , Zhihong Wang , dev@dpdk.org, Dilshod Urazov , stable@dpdk.org Message-ID: <20191008054650.GA22478@___> References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com> <1569944672-24754-3-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1569944672-24754-3-git-send-email-arybchenko@solarflare.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > This driver supports none of DCB, RSS or VMDQ modes, > therefore must check and return error if configured incorrectly. > > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: stable@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > --- > drivers/net/virtio/virtio_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 7261109dd..0af4fc392 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -2071,6 +2071,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) > PMD_INIT_LOG(DEBUG, "configure"); > req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; > > + if (rxmode->mq_mode != ETH_MQ_RX_NONE) { > + PMD_DRV_LOG(ERR, > + "Unsupported Rx multi queue mode %d", > + rxmode->mq_mode); > + return -EINVAL; > + } We need similar checks for Tx as well. Thanks, Tiwei > + > if (dev->data->dev_conf.intr_conf.rxq) { > ret = virtio_init_device(dev, hw->req_guest_features); > if (ret < 0) > -- > 2.17.1 >