DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, maxime.coquelin@redhat.com,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 3/3] vhost: prevent zero copy mode if iommu is on
Date: Tue, 8 Oct 2019 14:23:14 +0800	[thread overview]
Message-ID: <20191008062314.GA25865@___> (raw)
In-Reply-To: <20190927183759.18816-4-amorenoz@redhat.com>

On Fri, Sep 27, 2019 at 08:37:59PM +0200, Adrian Moreno wrote:
> The simltaneous use of dequeue_zero_copy and IOMMU is problematic.
> Not only because IOVA_VA mode is not supported but also because the
> potential invalidation of guest pages while the buffers are in use,
> is not handled.
> 
> Prevent these two features to be enabled simultaneosly.
> 
> Fixes: 69c90e98f483 ("vhost: enable IOMMU support")
> Cc: maxime.coquelin@redhat.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
> ---
>  lib/librte_vhost/socket.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 274988c4d..534a7ffe3 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -871,6 +871,14 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>  	}
>  	vsocket->dequeue_zero_copy = flags & RTE_VHOST_USER_DEQUEUE_ZERO_COPY;
>  
> +	if (vsocket->dequeue_zero_copy &&
> +	   (flags & RTE_VHOST_USER_IOMMU_SUPPORT)) {

It's better to add one more space before '(flags ...'

> +		RTE_LOG(ERR, VHOST_CONFIG,
> +			"error: enabling dequeue zero copy and IOMMU features "
> +			"simultaneously is not supported\n");
> +		goto out_mutex;
> +	}
> +
>  	/*
>  	 * Set the supported features correctly for the builtin vhost-user
>  	 * net driver.
> -- 
> 2.21.0
> 

  reply	other threads:[~2019-10-08  6:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 18:37 [dpdk-dev] [PATCH v3 0/3] vhost: add support for IOVA_VA mode Adrian Moreno
2019-09-27 18:37 ` [dpdk-dev] [PATCH v3 1/3] vhost: translate incoming log address to gpa Adrian Moreno
2019-09-27 18:37 ` [dpdk-dev] [PATCH v3 2/3] vhost: convert buffer addresses to GPA for logging Adrian Moreno
2019-10-08  6:30   ` Tiwei Bie
2019-10-08  7:38     ` Adrian Moreno
2019-10-08  7:43       ` Maxime Coquelin
2019-10-08  8:01         ` Tiwei Bie
2019-10-08  8:25           ` Adrian Moreno
2019-09-27 18:37 ` [dpdk-dev] [PATCH v3 3/3] vhost: prevent zero copy mode if iommu is on Adrian Moreno
2019-10-08  6:23   ` Tiwei Bie [this message]
2019-10-08  7:40     ` Adrian Moreno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008062314.GA25865@___ \
    --to=tiwei.bie@intel.com \
    --cc=amorenoz@redhat.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).