From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EFA9A2F6B for ; Tue, 8 Oct 2019 17:28:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E1DE1D41B; Tue, 8 Oct 2019 17:28:10 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 8FDBD322C for ; Tue, 8 Oct 2019 17:28:08 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id b128so10998255pfa.1 for ; Tue, 08 Oct 2019 08:28:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P9HbOHXMyF0WBFZvOY+5dhK+/6vXYiIvJ/JlQRYeqMY=; b=iEmwP+Wq7TmeNCgzk4p/5ppHMxtSUcg5WKhwPbq8mvCnrtyCdvMHKE41/kHZ1RdLrn 8OiNv8Jl7lDNN0JIbM3+SF3ZAfdo3oNensBBwyZREkG86dC1lZRD2hIb0efthX+Tzz1u aIho/zu8EFW+bS/GNNzCjTU1posuRvynsEQrYtyyDRTHoqOqol8bD6V1iqKsl47tmg6H LRDZDygNCZJBqX1hkQlj4FtBTANc/HJnF/JwxLgzhgu7PazfcZpLo8ymPn2P9m81JmbM zZ9L3/jofy8zGFJyDbC9IpH2XeQWfZnULSFmoiKPmiR4IVA3ieHt9fW/zbKB/z7ijEWo atLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P9HbOHXMyF0WBFZvOY+5dhK+/6vXYiIvJ/JlQRYeqMY=; b=p5VNSekGIDti64aQyrHXE4S/KCwUhUFZYSPr4AScYOQ6gHOQf20wBVzgflaJ897jhv fvvUFBIz/mSvYiql536YP19HKtGhGLjXkpz+PmPpGBbdvi/2HN1lnJiFRr+nKIkg7iy7 /hQbbUvW5yehHhTU/yLi3D2VVZ+G8Nv/ggWGWGskFt75+6NHbZTscJ7RI84cac4Sspov z1+BxJlYXJZLryhvV3SWT5QJWZn+cRt/78g0sWIn2nnwf8MZ+tOP/INeeLs1NSMZxwh8 LsAGE3ZMn6qXbxHOhS55xM2W8u/v13QG8O243J9rA5QZgVDFFnupdN6FDmLc6/5G8RFS wz2Q== X-Gm-Message-State: APjAAAVjXBZPNd/usZxGiWg5bjvM8E0I0yyQO/Vvy988hEDbmKb+MnuE GXnrezwvwfJh1BOSeeUbpE2MVf6saf2dtg== X-Google-Smtp-Source: APXvYqwep32jKLYFGMgL06mGGOKporD8DcO94E2quz8yE9UP9lOJ2+3PxUgzCHB/MjsdAxnHPyd5pQ== X-Received: by 2002:a63:fb08:: with SMTP id o8mr37205048pgh.312.1570548487378; Tue, 08 Oct 2019 08:28:07 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id s3sm1980373pjq.32.2019.10.08.08.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 08:28:07 -0700 (PDT) Date: Tue, 8 Oct 2019 08:27:59 -0700 From: Stephen Hemminger To: Olivier Matz Cc: dev@dpdk.org Message-ID: <20191008082759.5bc4a65c@hermes.lan> In-Reply-To: <20191008090334.GS7277@glumotte.dev.6wind.com> References: <20190928003758.18489-1-stephen@networkplumber.org> <20191007154343.8556-1-stephen@networkplumber.org> <20191007154343.8556-5-stephen@networkplumber.org> <20191008090334.GS7277@glumotte.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 4/5] mbuf: add a pktmbuf copy routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 8 Oct 2019 11:03:34 +0200 Olivier Matz wrote: > > > > +/** > > + * Creates a full copy of a given packet mbuf. > > Although it's not consistent everywhere, I think the imperative > form is preferred ("Create" instead of "Creates"). > > > + * Copies all the data from a given packet mbuf to a newly allocated > > + * set of mbufs. > > Same here > > > + * > > + * @param m > > + * The packet mbuf to be cloned. > > cloned -> copied (there are some other occurrences of "clone" below) This comment was modified from the mbuf_clone description. The two should use same grammar. Don't really care which way but should be consistent between these two. Will fix both to match your suggestion.