From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E0C83A3160
for <public@inbox.dpdk.org>; Wed, 9 Oct 2019 17:34:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9A5F01E986;
Wed, 9 Oct 2019 17:34:17 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com
[67.231.148.174]) by dpdk.org (Postfix) with ESMTP id B1CCB1E981
for <dev@dpdk.org>; Wed, 9 Oct 2019 17:34:15 +0200 (CEST)
Received: from pps.filterd (m0045849.ppops.net [127.0.0.1])
by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
x99FRMEO028829; Wed, 9 Oct 2019 08:34:14 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=pfpt0818;
bh=5YmAd0o/3ev8X79zszPymrbCQ9E+GNgQO1aZSIgQ93o=;
b=TlNpbCkbMU3o3y0WAnTBO4fXqYFpiVo5ehMHroMMSmC8ML6kFq/tmY4qQWjBApZ3Jmsr
fUN7zc5Ss1YGtAj7WAtGOt/U8dsnao8ThL7RQ9FTRFw2KThdxgF7csmKiYv3q7f/KgGL
vPH3hW0Tp3s7bGdFXkanFwsoVHhkMjxjEfVqL74a0RhodhTIHM83Dv3XR2C0hCtH/rU/
0i+5RMb+MD+NhivldO/1R+hL58IG6JwqkzzXhU3a/Nb1WSnDgrLzHWQG1F4SADybym3s
/M8x/WWEKfxuyHLj5V04o9JwxLLRwkzeTWu3A+zeP9Qx8XUtrPgxt8xPT0lNrY9Um5Vo Ag==
Received: from sc-exch03.marvell.com ([199.233.58.183])
by mx0a-0016f401.pphosted.com with ESMTP id 2vh5rqjq6d-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Wed, 09 Oct 2019 08:34:14 -0700
Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com
(10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 9 Oct
2019 08:34:13 -0700
Received: from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com
(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend
Transport; Wed, 9 Oct 2019 08:34:12 -0700
Received: from BG-LT7430.marvell.com (bg-lt7430.marvell.com [10.28.17.68])
by maili.marvell.com (Postfix) with ESMTP id ED5D73F703F;
Wed, 9 Oct 2019 08:34:09 -0700 (PDT)
From: <pbhagavatula@marvell.com>
To: <arybchenko@solarflare.com>, <jerinj@marvell.com>, John McNamara
<john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
CC: <dev@dpdk.org>, Pavan Nikhilesh <pbhagavatula@marvell.com>
Date: Wed, 9 Oct 2019 21:03:52 +0530
Message-ID: <20191009153357.926-4-pbhagavatula@marvell.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20191009153357.926-1-pbhagavatula@marvell.com>
References: <20191007065155.1756-1-pbhagavatula@marvell.com>
<20191009153357.926-1-pbhagavatula@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8
definitions=2019-10-09_07:2019-10-08,2019-10-09 signatures=0
Subject: [dpdk-dev] [PATCH v10 3/7] ethdev: add flow action type update as
an offload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to
enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and
`rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and
`RTE_FLOW_ACTION_FLAG` are enabled.
PMDs notify the validity of `rte_mbuf::hash:fdir::hi` to the applcation
by enabling `PKT_RX_FDIR_ID` flag in `rte_mbuf::ol_flags`.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/nics/features.rst | 12 ++++++++++++
doc/guides/rel_notes/release_19_11.rst | 9 +++++++++
lib/librte_ethdev/rte_ethdev.c | 1 +
lib/librte_ethdev/rte_ethdev.h | 1 +
lib/librte_ethdev/rte_flow.h | 6 ++++--
5 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst
index f7c6d918f..9737ff7a1 100644
--- a/doc/guides/nics/features.rst
+++ b/doc/guides/nics/features.rst
@@ -594,6 +594,18 @@ Allows application to set ptypes it is interested in.
* **[provides] mbuf**: ``mbuf.packet_type``.
+.. _nic_features_flow_flag_mark:
+
+Flow flag/mark update
+---------------------
+
+Supports flow action type update to ``mbuf.ol_flags`` and ``mbuf.hash.fdir.hi``.
+
+* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:DEV_RX_OFFLOAD_FLOW_MARK``.
+* **[provides] mbuf**: ``mbuf.ol_flags:PKT_RX_FDIR``, ``mbuf.ol_flags:PKT_RX_FDIR_ID;``,
+ ``mbuf.hash.fdir.hi``
+
+
.. _nic_features_timesync:
Timesync
diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst
index 55b334a6d..b319a4339 100644
--- a/doc/guides/rel_notes/release_19_11.rst
+++ b/doc/guides/rel_notes/release_19_11.rst
@@ -94,6 +94,15 @@ New Features
* PMDs notify the validity of `rte_mbuf::hash:rss` to the application
by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.
+* **Added Rx offload flag to enable or disable flow action type update**
+
+ * Add new Rx offload flag `DEV_RX_OFFLOAD_FLOW_MARK` that can be used to
+ enable/disable PMDs write to `rte_mbuf::hash::fdir::hi` and
+ `rte_mbuf::ol_flags` when flow actions `RTE_FLOW_ACTION_MARK` and
+ `RTE_FLOW_ACTION_FLAG` are enabled.
+ * PMDs notify the validity of `rte_mbuf::hash:fdir::hi` to the application
+ by enabling `PKT_RX_FDIR_ID` flag in `rte_mbuf::ol_flags`.
+
Removed Items
-------------
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 096e6a13c..71d915213 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -130,6 +130,7 @@ static const struct {
RTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM),
RTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM),
RTE_RX_OFFLOAD_BIT2STR(RSS_HASH),
+ RTE_RX_OFFLOAD_BIT2STR(FLOW_MARK),
};
#undef RTE_RX_OFFLOAD_BIT2STR
diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 6110c1772..db32f5589 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1014,6 +1014,7 @@ struct rte_eth_conf {
#define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000
#define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000
#define DEV_RX_OFFLOAD_RSS_HASH 0x00080000
+#define DEV_RX_OFFLOAD_FLOW_MARK 0x00100000
#define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \
DEV_RX_OFFLOAD_UDP_CKSUM | \
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index 354cb1dd0..5d62686c0 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -1316,7 +1316,8 @@ enum rte_flow_action_type {
/**
* Attaches an integer value to packets and sets PKT_RX_FDIR and
- * PKT_RX_FDIR_ID mbuf flags.
+ * PKT_RX_FDIR_ID mbuf flags when
+ * `rx_mode:offloads:DEV_RX_OFFLOAD_FLOW_MARK` is enabled.
*
* See struct rte_flow_action_mark.
*/
@@ -1324,7 +1325,8 @@ enum rte_flow_action_type {
/**
* Flags packets. Similar to MARK without a specific value; only
- * sets the PKT_RX_FDIR mbuf flag.
+ * sets the PKT_RX_FDIR mbuf flag when
+ * `rx_mode:offloads:DEV_RX_OFFLOAD_FLOW_MARK` is enabled.
*
* No associated configuration structure.
*/
--
2.17.1