From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: avoid the parsed devargs value being overwritten
Date: Mon, 14 Oct 2019 16:24:38 +0800 [thread overview]
Message-ID: <20191014082438.GD3725@intel.com> (raw)
In-Reply-To: <20191009130716.80418-1-haiyue.wang@intel.com>
On 10/09, Haiyue Wang wrote:
>If the default dev args 'proto_xtr' is not in the first position, it
>will overwrite the parsed queue map value, so use an new variable to
>save the default.
>
>And enhance the error message printing to show the right information.
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_ethdev.c | 44 +++++++++++++++++++++++++-----------
> drivers/net/ice/ice_ethdev.h | 1 +
> 2 files changed, 32 insertions(+), 13 deletions(-)
>
[snip]
>@@ -2126,6 +2142,8 @@ ice_dev_close(struct rte_eth_dev *dev)
> rte_free(hw->port_info);
> hw->port_info = NULL;
> ice_shutdown_all_ctrlq(hw);
>+ rte_free(pf->proto_xtr);
>+ pf->proto_xtr = NULL;
These two lines seems irrelevant to this patch, I noticed that the resource
free operation was contained in the original patch, and they are removed
unexpectedly by commit bd513ece3c40 ("net/ice: release port upon close"),
sorry for not catching it when reviewing.
Prefer one individual patch for the fix.
Thanks,
Xiaolong
>
> dev->dev_ops = NULL;
> dev->rx_pkt_burst = NULL;
>diff --git a/drivers/net/ice/ice_ethdev.h b/drivers/net/ice/ice_ethdev.h
>index 182c6f611..2fd98817b 100644
>--- a/drivers/net/ice/ice_ethdev.h
>+++ b/drivers/net/ice/ice_ethdev.h
>@@ -288,6 +288,7 @@ struct ice_pf {
> */
> struct ice_devargs {
> int safe_mode_support;
>+ uint8_t proto_xtr_dflt;
> uint8_t proto_xtr[ICE_MAX_QUEUE_NUM];
> };
>
>--
>2.17.1
>
next prev parent reply other threads:[~2019-10-14 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:07 Haiyue Wang
2019-10-14 8:24 ` Ye Xiaolong [this message]
2019-10-14 13:51 ` Wang, Haiyue
2019-10-14 14:50 ` [dpdk-dev] [PATCH v2 0/2] net/ice: protocol extraction related issues Haiyue Wang
2019-10-14 14:50 ` [dpdk-dev] [PATCH v2 1/2] net/ice: fix the missed memory free when dev is closed Haiyue Wang
2019-10-14 14:50 ` [dpdk-dev] [PATCH v2 2/2] net/ice: avoid the parsed devargs value being overwritten Haiyue Wang
2019-10-14 23:21 ` [dpdk-dev] [PATCH v2 0/2] net/ice: protocol extraction related issues Ye Xiaolong
2019-10-16 3:05 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014082438.GD3725@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).