From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>,
dariusz.stojaszyk@intel.com, Seth Howell <seth.howell@intel.com>
Subject: Re: [dpdk-dev] [PATCH] rte_bus_pci: remove unneeded library dependency.
Date: Mon, 14 Oct 2019 17:16:37 +0200 [thread overview]
Message-ID: <20191014151637.ihhyqzfmsz2mvyds@bidouze.vm.6wind.com> (raw)
In-Reply-To: <CAJFAV8w-oG8_KABjE8fPmDM6MRZKDWf3eq-NqqdXRnh-2XtkBw@mail.gmail.com>
On Mon, Oct 14, 2019 at 04:32:54PM +0200, David Marchand wrote:
> On Fri, Oct 11, 2019 at 10:56 PM Seth Howell <seth.howell@intel.com> wrote:
> >
> > The makefile in drivers/bus/pci specified rte_ethdev as a dependency for
> > the library. However there are no actual symbols from librte_ethdev used
> > in librte_bus_pci.
> >
> > Including librte_ethdev as a dependency only becomes a problem in some
> > niche cases like when attempting to build the rte_bus_pci library as a
> > shared object without building the rte_ethdev library.
> >
> > I specifically ran into this when trying to build the DPDK included as
> > an SPDK submodule on a FreeBSD machine. I figure that since there are no
> > real dependencies between the two, we should enable building
> > librte_bus_pci without librte_ethdev.
> >
> > Signed-off-by: Seth Howell <seth.howell@intel.com>
> > ---
> > drivers/bus/pci/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bus/pci/Makefile b/drivers/bus/pci/Makefile
> > index 68c1f3fde..45d12427a 100644
> > --- a/drivers/bus/pci/Makefile
> > +++ b/drivers/bus/pci/Makefile
> > @@ -25,7 +25,7 @@ CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
> > CFLAGS += -DALLOW_EXPERIMENTAL_API
> >
> > LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
> > -LDLIBS += -lrte_ethdev -lrte_pci -lrte_kvargs
> > +LDLIBS += -lrte_pci -lrte_kvargs
> >
> > include $(RTE_SDK)/drivers/bus/pci/$(SYSTEM)/Makefile
> > SRCS-$(CONFIG_RTE_LIBRTE_PCI_BUS) := $(addprefix $(SYSTEM)/,$(SRCS))
> > --
> > 2.17.2
> >
>
> At a first glance, this patch seems valid, Gaëtan, could you have a look ?
> Could be worth a Fixes:.
>
> Thanks.
>
>
> --
> David Marchand
>
Hi,
Yes this is fine.
I've checked, when this Makefile was introduced first in v17.11, this
dependency was not needed either. This means the Fixes: can go back to c752998b5.
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2019-10-14 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 20:56 Seth Howell
2019-10-14 14:32 ` David Marchand
2019-10-14 15:16 ` Gaëtan Rivet [this message]
2019-10-25 8:43 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014151637.ihhyqzfmsz2mvyds@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dariusz.stojaszyk@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=seth.howell@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).