[dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes

[dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes

[asomalap]

From: Amaranath Somalapuram <asomalap@amd.com>

issue occurred during VPP testing, crash's issue in VPP when ccp used.
vpp max burst size is 256, and minimum queue pair required is 3.
Cc: stable@dpdk.org

Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
---
 drivers/crypto/ccp/ccp_pmd_private.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ccp/ccp_pmd_private.h b/drivers/crypto/ccp/ccp_pmd_private.h
index 7f2979e89..781050c31 100644
--- a/drivers/crypto/ccp/ccp_pmd_private.h
+++ b/drivers/crypto/ccp/ccp_pmd_private.h
@@ -31,9 +31,9 @@
 #endif
 
 /**< Maximum queue pairs supported by CCP PMD */
-#define CCP_PMD_MAX_QUEUE_PAIRS	1
+#define CCP_PMD_MAX_QUEUE_PAIRS	8
 #define CCP_NB_MAX_DESCRIPTORS 1024
-#define CCP_MAX_BURST 64
+#define CCP_MAX_BURST 256
 
 #include "ccp_dev.h"
 
-- 
2.17.1

Re: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes

[Akhil Goyal]

Title should be: crypto/ccp: update max qp and burst size.

> 
> From: Amaranath Somalapuram <asomalap@amd.com>
> 
> issue occurred during VPP testing, crash's issue in VPP when ccp used.
> vpp max burst size is 256, and minimum queue pair required is 3.

Please explain the issue appropriately in the description.
Does that mean, without VPP, this issue cannot be reproduced.

Add a fixes line with the commit which introduces this issue.


> Cc: stable@dpdk.org
> 
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
>  drivers/crypto/ccp/ccp_pmd_private.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/ccp_pmd_private.h
> b/drivers/crypto/ccp/ccp_pmd_private.h
> index 7f2979e89..781050c31 100644
> --- a/drivers/crypto/ccp/ccp_pmd_private.h
> +++ b/drivers/crypto/ccp/ccp_pmd_private.h
> @@ -31,9 +31,9 @@
>  #endif
> 
>  /**< Maximum queue pairs supported by CCP PMD */
> -#define CCP_PMD_MAX_QUEUE_PAIRS	1
> +#define CCP_PMD_MAX_QUEUE_PAIRS	8
>  #define CCP_NB_MAX_DESCRIPTORS 1024
> -#define CCP_MAX_BURST 64
> +#define CCP_MAX_BURST 256
> 
>  #include "ccp_dev.h"
> 
> --
> 2.17.1

Re: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes

[Somalapuram, Amaranath]

We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256

-----Original Message-----
From: Akhil Goyal <akhil.goyal@nxp.com> 
Sent: Tuesday, October 15, 2019 4:28 PM
To: Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>; dev@dpdk.org
Cc: stable@dpdk.org
Subject: RE: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes

[CAUTION: External Email]

Title should be: crypto/ccp: update max qp and burst size.

>
> From: Amaranath Somalapuram <asomalap@amd.com>
>
> issue occurred during VPP testing, crash's issue in VPP when ccp used.
> vpp max burst size is 256, and minimum queue pair required is 3.

Please explain the issue appropriately in the description.
Does that mean, without VPP, this issue cannot be reproduced.

Add a fixes line with the commit which introduces this issue.


> Cc: stable@dpdk.org
>
> Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> ---
>  drivers/crypto/ccp/ccp_pmd_private.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp_pmd_private.h
> b/drivers/crypto/ccp/ccp_pmd_private.h
> index 7f2979e89..781050c31 100644
> --- a/drivers/crypto/ccp/ccp_pmd_private.h
> +++ b/drivers/crypto/ccp/ccp_pmd_private.h
> @@ -31,9 +31,9 @@
>  #endif
>
>  /**< Maximum queue pairs supported by CCP PMD */
> -#define CCP_PMD_MAX_QUEUE_PAIRS      1
> +#define CCP_PMD_MAX_QUEUE_PAIRS      8
>  #define CCP_NB_MAX_DESCRIPTORS 1024
> -#define CCP_MAX_BURST 64
> +#define CCP_MAX_BURST 256
>
>  #include "ccp_dev.h"
>
> --
> 2.17.1

Re: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes

[Akhil Goyal]

> 
> We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256
> 
> 
Description should have appropriate information explaining what the issue is and
What is done in the patch to fix the issue.

> 
> Title should be: crypto/ccp: update max qp and burst size.
> 
> >
> > From: Amaranath Somalapuram <asomalap@amd.com>
> >
> > issue occurred during VPP testing, crash's issue in VPP when ccp used.
> > vpp max burst size is 256, and minimum queue pair required is 3.
> 
> Please explain the issue appropriately in the description.
> Does that mean, without VPP, this issue cannot be reproduced.
> 
> Add a fixes line with the commit which introduces this issue.
> 
> 
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Amaranath Somalapuram <asomalap@amd.com>
> > ---
> >  drivers/crypto/ccp/ccp_pmd_private.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/crypto/ccp/ccp_pmd_private.h
> > b/drivers/crypto/ccp/ccp_pmd_private.h
> > index 7f2979e89..781050c31 100644
> > --- a/drivers/crypto/ccp/ccp_pmd_private.h
> > +++ b/drivers/crypto/ccp/ccp_pmd_private.h
> > @@ -31,9 +31,9 @@
> >  #endif
> >
> >  /**< Maximum queue pairs supported by CCP PMD */
> > -#define CCP_PMD_MAX_QUEUE_PAIRS      1
> > +#define CCP_PMD_MAX_QUEUE_PAIRS      8
> >  #define CCP_NB_MAX_DESCRIPTORS 1024
> > -#define CCP_MAX_BURST 64
> > +#define CCP_MAX_BURST 256
> >
> >  #include "ccp_dev.h"
> >
> > --
> > 2.17.1