Re: [dpdk-dev] [PATCH v3 0/9] Implement the new ABI policy and add helper scripts

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Oct 16, 2019 at 06:03:35PM +0100, Anatoly Burakov wrote:
> This patchset prepares the codebase for the new ABI policy and
> adds a few helper scripts.
> 
> There are two new scripts for managing ABI versions added. The
> first one is a Python script that will read in a .map file,
> flatten it and update the ABI version to the ABI version
> specified on the command-line.
> 
> The second one is a shell script that will run the above mentioned
> Python script recursively over the source tree and set the ABI
> version to either that which is defined in config/ABI_VERSION, or
> a user-specified one.
> 
> Example of its usage: buildtools/update-abi.sh 20.0
> 
> This will recurse into lib/ and drivers/ directory and update
> whatever .map files it can find.
> 
> The other shell script that's added is one that can take in a .so
> file and ensure that its declared public ABI matches either
> current ABI, next ABI, or EXPERIMENTAL. This was moved to the
> last commit because it made no sense to have it beforehand.
> 
> The source tree was verified to follow the new ABI policy using
> the following command (assuming built binaries are in build/):
> 
> find ./build/lib ./build/drivers -name  \*.so \
> 	-exec ./buildtools/check-abi-version.sh {} \; -print
> 
> This returns 0.
> 
> Changes since v2:
> - Addressed Bruce's review comments
> - Removed single distributor mode as per Dave's suggestion
> 
> Changes since v1:
> - Reordered patchset to have removal of old ABI's before introducing
>   the new one to avoid compile breakages between patches
> - Added a new patch fixing missing symbol in octeontx common
> - Split script commits into multiple commits and reordered them
> - Re-generated the ABI bump commit
> - Verified all scripts to work
> 
> Anatoly Burakov (2):
>   buildtools: add ABI update shell script
>   drivers/octeontx: add missing public symbol
> 
> Marcin Baran (5):
>   config: change ABI versioning to global
>   timer: remove deprecated code
>   lpm: remove deprecated code
>   distributor: remove deprecated code
>   buildtools: add ABI versioning check script
> 
> Pawel Modrak (2):
>   buildtools: add script for updating symbols abi version
>   build: change ABI version to 20.0
> 

For me, bar the one small open question on driver paths, this looks pretty
good.

Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>