From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7F7D4A317C
for <public@inbox.dpdk.org>; Thu, 17 Oct 2019 22:40:40 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 41FB51E95B;
Thu, 17 Oct 2019 22:40:40 +0200 (CEST)
Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com
[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 6D5DA1E957
for <dev@dpdk.org>; Thu, 17 Oct 2019 22:40:39 +0200 (CEST)
Received: by mail-pg1-f193.google.com with SMTP id k20so2032592pgi.1
for <dev@dpdk.org>; Thu, 17 Oct 2019 13:40:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=XBLO8TT9lfF04Gu2jX8c8FznpSPsACVRYmhEaCxHieE=;
b=avTZKyl95SfDg21TIztw0mIGzQxsuHEy22nwK72LM+RZgT/eb4sTWrhEUIeVfDj1GW
gnOHkHLeTjcHwYBT4WOHHVJkdEzw7Xkt5HhYqHdjH75CCk60D0lDGtanNTFm97BJiTC+
eAWJukgGhKrXdM904TTOeJQ/m1yXCJY8sja23KlD3WA0fpZj12YUnYDUjetjJdCm1BRP
9fJKkpueOldk/laRBEBUeW+W7lPubht4cZKOd/Sii9i38AvNqzGBRIHYgO3dn0Y6sddy
lyQ+9HEYEn5IYQU4U2ojQO0zuUc+qzDsagXHnzKIUjY3s2Z3P/pZptYH+FU7Ryza0wAH
Ih8Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=XBLO8TT9lfF04Gu2jX8c8FznpSPsACVRYmhEaCxHieE=;
b=fFwbcTLgWcB2q0s71X6CFyv9AcUjwZUhB5lDH2UyWcvLYTQZr7jMgq0WSkVQ1YLuAy
MpsTSIemAEwoyF1uEjPNlxKEwAZPvlaHPZ1pv0XXloUhk3PR1CeY4KFCmwbKblaJgXmK
TqHpRaHX9AhMsiGJto5ij6NU82VprUw/AfxN1NnO65/5GVt+hrIYV+Qjyplm2DssjwkE
QFAAfiBY8MuT02LmjKTKX507EQN0OwA/y7yx5PmFKgrs5X/GMZiMvv3EcReeRtZYZ92F
Gc2p6rdnEis5F2NzDts65mjKnvJg4yDEL/vXqZPuiq+zx789+XfKUVkrfoEn8dtoLk3c
jPyw==
X-Gm-Message-State: APjAAAXGqrhqQHpGGYwArZtBU7NH21g34cAld4fN1/64J5u14VKP06YI
hFlSA0BM27lJxoiDIrxBny+rKg==
X-Google-Smtp-Source: APXvYqz04RsSBwEAhc+tuKK6qD+WIC2tJfxJu7vMa+I3rbemxvbATtJjTMq8Fq/UQnjStR4OZNujhw==
X-Received: by 2002:a63:b61:: with SMTP id a33mr6369321pgl.247.1571344838564;
Thu, 17 Oct 2019 13:40:38 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id 62sm3455098pfg.164.2019.10.17.13.40.38
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 17 Oct 2019 13:40:38 -0700 (PDT)
Date: Thu, 17 Oct 2019 13:40:36 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: olivier.matz@6wind.com, sthemmin@microsoft.com, jerinj@marvell.com,
bruce.richardson@intel.com, david.marchand@redhat.com,
pbhagavatula@marvell.com, konstantin.ananyev@intel.com,
drc@linux.vnet.ibm.com, hemant.agrawal@nxp.com, dev@dpdk.org,
dharmik.thakkar@arm.com, ruifeng.wang@arm.com, gavin.hu@arm.com
Message-ID: <20191017134036.773c46d7@hermes.lan>
In-Reply-To: <20191017200807.20772-2-honnappa.nagarahalli@arm.com>
References: <20190906190510.11146-1-honnappa.nagarahalli@arm.com>
<20191017200807.20772-1-honnappa.nagarahalli@arm.com>
<20191017200807.20772-2-honnappa.nagarahalli@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v5 1/3] lib/ring: apis to support
configurable element size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, 17 Oct 2019 15:08:05 -0500
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote:
> /* count must be a power of 2 */
> if ((!POWEROF2(count)) || (count > RTE_RING_SZ_MASK )) {
> RTE_LOG(ERR, RING,
> - "Requested size is invalid, must be power of 2, and "
> - "do not exceed the size limit %u\n", RTE_RING_SZ_MASK);
> + "Requested number of elements is invalid, must be "
> + "power of 2, and do not exceed the limit %u\n",
Error messages often go to syslog. Please don't use multi-line messages, syslog doesn't handle it.
Better to be less wordy