From: Robin Jarry <robin.jarry@6wind.com>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, Andrius Sirvys <andrius.sirvys@intel.com>,
Ciara Power <ciara.power@intel.com>,
Reshma Pattan <reshma.pattan@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] usertools: fix py3 syntax errors with dpdk-telemetry-client.py
Date: Thu, 17 Oct 2019 19:32:12 +0200 [thread overview]
Message-ID: <20191017173212.1038-1-robin.jarry@6wind.com> (raw)
When running the dpdk-telemetry-client.py with python 3, we get the
following syntax errors:
File "usertools/dpdk-telemetry-client.py", line 70
print "\nResponse: \n", str(data)
^
SyntaxError: invalid syntax
File "usertools/dpdk-telemetry-client.py", line 93
print "\nResponse: \n", str(data)
^
SyntaxError: invalid syntax
File "usertools/dpdk-telemetry-client.py", line 111
file_path = sys.argv[1]
^
TabError: inconsistent use of tabs and spaces in indentation
Import print_function from __future__ and add parentheses where missing.
Also, use spaces for indentation everywhere.
Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
Fixes: 53f293c9a783 ("usertools: replace unsafe input function")
Fixes: 4080e46c8078 ("telemetry: support global metrics")
Cc: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: Ciara Power <ciara.power@intel.com>
Cc: Kevin Laatz <kevin.laatz@intel.com>
Cc: Reshma Pattan <reshma.pattan@intel.com>
Cc: stable@dpdk.org
Signed-off-by: Robin Jarry <robin.jarry@6wind.com>
---
usertools/dpdk-telemetry-client.py | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index 60fe97af79a8..e06d6306cbd5 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -2,6 +2,8 @@
# SPDK-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Intel Corporation
+from __future__ import print_function
+
import socket
import os
import sys
@@ -16,9 +18,9 @@
DEFAULT_FP = "/var/run/dpdk/default_client"
try:
- raw_input # Python 2
+ raw_input # Python 2
except NameError:
- raw_input = input # Python 3
+ raw_input = input # Python 3
class Socket:
@@ -74,7 +76,7 @@ def unregister(self): # Unregister a given client
def requestMetrics(self): # Requests metrics for given client
self.socket.client_fd.send(METRICS_REQ)
data = self.socket.client_fd.recv(BUFFER_SIZE)
- print "\nResponse: \n", str(data)
+ print("\nResponse: \n", str(data))
def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
@@ -88,7 +90,7 @@ def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics f
def requestGlobalMetrics(self): #Requests global metrics for given client
self.socket.client_fd.send(GLOBAL_METRICS_REQ)
data = self.socket.client_fd.recv(BUFFER_SIZE)
- print "\nResponse: \n", str(data)
+ print("\nResponse: \n", str(data))
def interactiveMenu(self, sleep_time): # Creates Interactive menu within the script
while self.choice != 4:
@@ -121,10 +123,10 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
sleep_time = 1
file_path = ""
if (len(sys.argv) == 2):
- file_path = sys.argv[1]
+ file_path = sys.argv[1]
else:
print("Warning - No filepath passed, using default (" + DEFAULT_FP + ").")
- file_path = DEFAULT_FP
+ file_path = DEFAULT_FP
client = Client()
client.getFilepath(file_path)
client.register()
--
2.23.0
next reply other threads:[~2019-10-17 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 17:32 Robin Jarry [this message]
2019-10-17 17:37 ` Stephen Hemminger
2019-10-27 20:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017173212.1038-1-robin.jarry@6wind.com \
--to=robin.jarry@6wind.com \
--cc=andrius.sirvys@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).