DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Ting Xu <ting.xu@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com,
	xiaolong.ye@intel.com, qiming.yang@intel.com,
	john.mcnamara@intel.com, marko.kovacevic@intel.com,
	qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag
Date: Fri, 18 Oct 2019 10:38:11 +0200	[thread overview]
Message-ID: <20191018083811.mwau5g3shqgz66bw@platinum> (raw)
In-Reply-To: <9f054f84c5ae5cb871d86ace17f7c3ca658fb890.1568968178.git.ting.xu@intel.com>

Hi,

On Fri, Sep 20, 2019 at 08:36:23AM +0000, Ting Xu wrote:
> Add GTP tunnel type flag in mbuf for future use in GTP
> checksum offload.
> 
> Signed-off-by: Ting Xu <ting.xu@intel.com>
> ---
>  lib/librte_mbuf/rte_mbuf.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 98225ec80..0a5d67d9a 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -251,6 +251,8 @@ extern "C" {
>  /** TX packet with MPLS-in-UDP RFC 7510 header. */
>  #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45)
>  #define PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45)
> +#define PKT_TX_TUNNEL_GTP       (0x7ULL << 45)
> +
>  /**
>   * Generic IP encapsulated tunnel type, used for TSO and checksum offload.
>   * It can be used for tunnels which are not standards or listed above.

Some updates are missing, for instance in rte_get_tx_ol_flag_name().
Please look what was done for other flags.

Please, can you describe in more details what is expected in the packet
header?

Thanks,
Olivier

  reply	other threads:[~2019-10-18  8:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20  8:36 [dpdk-dev] [PATCH v1 0/2] net/ice: enable GTP checksum offload Ting Xu
2019-09-20  8:36 ` [dpdk-dev] [PATCH v1 1/2] lib/mbuf: add GTP tunnel type flag Ting Xu
2019-10-18  8:38   ` Olivier Matz [this message]
2019-10-21  2:38     ` Xu, Ting
2019-10-21  9:59   ` [dpdk-dev] [PATCH v2 0/2] support GTP Tx checksum offload Ting Xu
2019-10-23 14:56     ` Ferruh Yigit
2019-10-21 10:00   ` [dpdk-dev] [PATCH v2 1/2] lib/mbuf: add GTP tunnel type flag Ting Xu
2019-10-23 14:56     ` Ferruh Yigit
2019-10-21 10:00   ` [dpdk-dev] [PATCH v2 2/2] net/ice: add GTP tunnel type in tunneling parse Ting Xu
2019-10-23 14:56     ` Ferruh Yigit
2019-09-20  8:36 ` [dpdk-dev] [PATCH v1 2/2] net/ice: add GTP " Ting Xu
2019-10-17  1:37 ` [dpdk-dev] [PATCH v1 0/2] net/ice: enable GTP checksum offload Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191018083811.mwau5g3shqgz66bw@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=ting.xu@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).