From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3F949A31F3
for <public@inbox.dpdk.org>; Sat, 19 Oct 2019 02:59:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 083961C042;
Sat, 19 Oct 2019 02:59:54 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 114D81C039
for <dev@dpdk.org>; Sat, 19 Oct 2019 02:59:52 +0200 (CEST)
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
18 Oct 2019 17:59:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.67,313,1566889200"; d="scan'208";a="209025790"
Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17])
by fmsmga001.fm.intel.com with ESMTP; 18 Oct 2019 17:59:50 -0700
Date: Sat, 19 Oct 2019 08:56:57 +0800
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Andy Pei <andy.pei@intel.com>
Cc: dev@dpdk.org, rosen.xu@intel.com, tianfei.zhang@intel.com,
qi.z.zhang@intel.com
Message-ID: <20191019005657.GD44515@intel.com>
References: <1570782089-182978-2-git-send-email-andy.pei@intel.com>
<1571037064-382519-1-git-send-email-andy.pei@intel.com>
<1571037064-382519-14-git-send-email-andy.pei@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1571037064-382519-14-git-send-email-andy.pei@intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Subject: Re: [dpdk-dev] [PATCH v9 13/18] raw/ifpga/base: add secure support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 10/14, Andy Pei wrote:
>From: Tianfei zhang <tianfei.zhang@intel.com>
>
>Add secure max10 device support.
>
>Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com>
>Signed-off-by: Andy Pei <andy.pei@intel.com>
>---
> drivers/raw/ifpga/base/ifpga_defines.h | 2 +
> drivers/raw/ifpga/base/ifpga_fme.c | 26 ++++--
> drivers/raw/ifpga/base/opae_intel_max10.c | 136 +++++++++++++++++++++++++-----
> drivers/raw/ifpga/base/opae_intel_max10.h | 80 +++++++++++++-----
> 4 files changed, 197 insertions(+), 47 deletions(-)
>
>+static int
>+max10_secure_hw_init(struct intel_max10_device *dev)
>+{
>+ int offset, sysmgr_offset = 0;
>+ char *fdt_root;
>+
>+ fdt_root = dev->fdt_root;
>+ if (!fdt_root) {
>+ dev_debug(dev, "skip init as not find Device Tree\n");
>+ return 0;
>+ }
>+
>+ fdt_for_each_subnode(offset, fdt_root, 0) {
>+ if (!fdt_node_check_compatible(fdt_root, offset,
>+ "intel-max10,system-manager"))
>+ sysmgr_offset = offset;
>+ break;
>+ }
Do you miss a brace for the if block? See compilation error below:
dpdk/drivers/raw/ifpga/base/opae_intel_max10.c:541:3: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
if (!fdt_node_check_compatible(fdt_root, offset,
^~
/home/yexl/workspace/dpdk/drivers/raw/ifpga/base/opae_intel_max10.c:544:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
break;
^~~~~