From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Robin Jarry <robin.jarry@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] tools: add EditorConfig file
Date: Mon, 21 Oct 2019 10:01:37 +0100 [thread overview]
Message-ID: <20191021090137.GA938@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191018090825.4df2ac5f@hermes.lan>
On Fri, Oct 18, 2019 at 09:08:25AM -0700, Stephen Hemminger wrote:
> On Fri, 18 Oct 2019 17:56:48 +0200
> Robin Jarry <robin.jarry@6wind.com> wrote:
>
> > 2019-10-18, Stephen Hemminger:
> > > Why not add this (since git doesn't like trailing whitespace).
> > >
> > > trim_trailing_whitespace=true
> >
> > Because EditorConfig applies the setting to the whole file when saving.
> > This has chances of trimming white space on lines that you did not
> > modify. I figure this is not what we want.
> >
>
>
> Current DPDK does not have trailing white space, I run a script over it
> perodically to check.
+1 for including this.
next prev parent reply other threads:[~2019-10-21 9:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 7:59 Robin Jarry
2019-10-18 9:08 ` Burakov, Anatoly
2019-10-18 15:47 ` Stephen Hemminger
2019-10-18 15:55 ` Robin Jarry
2019-10-18 15:48 ` Stephen Hemminger
2019-10-18 15:56 ` Robin Jarry
2019-10-18 16:08 ` Stephen Hemminger
2019-10-21 9:01 ` Bruce Richardson [this message]
2019-10-25 14:04 ` [dpdk-dev] [PATCH v2] devtools: " Robin Jarry
2020-02-22 20:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021090137.GA938@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=robin.jarry@6wind.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).