DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ciara Power <ciara.power@intel.com>
To: thomas@monjalon.net, ferruh.yigit@intel.com,
	arybchenko@solarflare.com, mtetsuyah@gmail.com,
	bruce.richardson@intel.com
Cc: dev@dpdk.org, Ciara Power <ciara.power@intel.com>
Subject: [dpdk-dev] [PATCH v2 0/2] enable virtual PMD promiscuous and multicast
Date: Mon, 21 Oct 2019 13:22:36 +0100	[thread overview]
Message-ID: <20191021122238.58852-1-ciara.power@intel.com> (raw)

When virtual PMDs are used to run sample applications, the application
fails due to the enable promiscuous function being called. The virtual
PMDs do not have dev_ops for enabling promiscuous mode, and return
-ENOTSUP as a result. 

Promiscuous and multicast modes are now initialised as enabled for the
virtual PMDs included in this patchset. When the enable promiscuous
function is called, a check now exists to allow the function return
successfully if the state is already enabled for the device. This allows
virtual PMDs run existing sample applications without failing.

---
v2:
* Removed dummy dev_ops functions.
* Added promiscuous state check in ethdev API functions.
* Initialised promiscuous and multicast states to enabled.

Ciara Power (2):
  ethdev: add check for device promiscuous state
  drivers/net: set enabled promiscuous and multicast

 drivers/net/kni/rte_eth_kni.c   |  2 ++
 drivers/net/null/rte_eth_null.c |  2 ++
 drivers/net/pcap/rte_eth_pcap.c |  2 ++
 drivers/net/ring/rte_eth_ring.c |  2 ++
 lib/librte_ethdev/rte_ethdev.c  | 22 ++++++++++++----------
 5 files changed, 20 insertions(+), 10 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-10-21 12:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 12:22 Ciara Power [this message]
2019-10-21 12:22 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add check for device promiscuous state Ciara Power
2019-10-21 18:39   ` Ferruh Yigit
2019-10-22  7:03   ` Andrew Rybchenko
2019-10-22  8:18     ` Ferruh Yigit
2019-10-21 12:22 ` [dpdk-dev] [PATCH v2 2/2] drivers/net: set enabled promiscuous and multicast Ciara Power
2019-10-21 18:40   ` Ferruh Yigit
2019-10-22  7:12   ` Andrew Rybchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191021122238.58852-1-ciara.power@intel.com \
    --to=ciara.power@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=mtetsuyah@gmail.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).