From: Stephen Hemminger <stephen@networkplumber.org>
To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)"
<jgrajcia@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length
Date: Tue, 22 Oct 2019 10:37:04 -0700 [thread overview]
Message-ID: <20191022103704.6cf05eff@hermes.lan> (raw)
In-Reply-To: <3462daa368f8426eac210f77dc812218@XCH-ALN-004.cisco.com>
On Tue, 22 Oct 2019 16:50:40 +0000
"Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" <jgrajcia@cisco.com> wrote:
> > Why does this not use abstract unix domain socket naming?
> > That would be much less error prone, because then the socket would
> > disappear when all applications using it are closed.
>
> How would that work with containers? I'll consider that for a new patch, maybe it could be optional?
>
Not sure, if they interact with fs namespaces (remember there really is no such
thing as containers). From unix(7)
Abstract sockets
Socket permissions have no meaning for abstract sockets: the process
umask(2) has no effect when binding an abstract socket, and changing
the ownership and permissions of the object (via fchown(2) and fch‐
mod(2)) has no effect on the accessibility of the socket.
Abstract sockets automatically disappear when all open references to
the socket are closed.
The abstract socket namespace is a nonportable Linux extension.
Also pathname length restrictions are only because of the sizeof default sockaddr_un struct.
Kernel will accept bigger lengths if passed a bigger sockaddr.
next prev parent reply other threads:[~2019-10-22 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 16:08 Jakub Grajciar
2019-10-22 16:32 ` Ferruh Yigit
2019-10-22 16:35 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-22 16:37 ` Stephen Hemminger
2019-10-22 16:50 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-22 17:37 ` Stephen Hemminger [this message]
2019-10-23 8:07 ` [dpdk-dev] [PATCH v2] " Jakub Grajciar
2019-10-23 17:42 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022103704.6cf05eff@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).