* [dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data
@ 2019-10-23 16:07 pbhagavatula
2019-10-31 10:50 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: pbhagavatula @ 2019-10-23 16:07 UTC (permalink / raw)
To: jerinj, Pavan Nikhilesh; +Cc: dev
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Recent profiling revealed few hotspots in octeontx2 event device
driver add prefetch hints to reduce stalls.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
drivers/event/octeontx2/otx2_worker.h | 1 +
drivers/event/octeontx2/otx2_worker_dual.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h
index 6f7842199..092ba71f7 100644
--- a/drivers/event/octeontx2/otx2_worker.h
+++ b/drivers/event/octeontx2/otx2_worker.h
@@ -280,6 +280,7 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[],
struct rte_mbuf *m = ev[0].mbuf;
const struct otx2_eth_txq *txq = otx2_ssogws_xtract_meta(m);
+ rte_prefetch_non_temporal(txq);
/* Perform header writes before barrier for TSO */
otx2_nix_xmit_prepare_tso(m, flags);
otx2_ssogws_order(ws, !ev->sched_type);
diff --git a/drivers/event/octeontx2/otx2_worker_dual.c b/drivers/event/octeontx2/otx2_worker_dual.c
index ff68472ef..7016eee4a 100644
--- a/drivers/event/octeontx2/otx2_worker_dual.c
+++ b/drivers/event/octeontx2/otx2_worker_dual.c
@@ -148,6 +148,7 @@ otx2_ssogws_dual_deq_ ##name(void *port, struct rte_event *ev, \
struct otx2_ssogws_dual *ws = port; \
uint8_t gw; \
\
+ rte_prefetch_non_temporal(ws); \
RTE_SET_USED(timeout_ticks); \
if (ws->swtag_req) { \
otx2_ssogws_swtag_wait((struct otx2_ssogws *) \
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data
2019-10-23 16:07 [dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data pbhagavatula
@ 2019-10-31 10:50 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2019-10-31 10:50 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: Jerin Jacob, dpdk-dev
On Wed, Oct 23, 2019 at 9:37 PM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Recent profiling revealed few hotspots in octeontx2 event device
> driver add prefetch hints to reduce stalls.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Applied to dpdk-next-eventdev/master. Thanks.
> ---
> drivers/event/octeontx2/otx2_worker.h | 1 +
> drivers/event/octeontx2/otx2_worker_dual.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/event/octeontx2/otx2_worker.h b/drivers/event/octeontx2/otx2_worker.h
> index 6f7842199..092ba71f7 100644
> --- a/drivers/event/octeontx2/otx2_worker.h
> +++ b/drivers/event/octeontx2/otx2_worker.h
> @@ -280,6 +280,7 @@ otx2_ssogws_event_tx(struct otx2_ssogws *ws, struct rte_event ev[],
> struct rte_mbuf *m = ev[0].mbuf;
> const struct otx2_eth_txq *txq = otx2_ssogws_xtract_meta(m);
>
> + rte_prefetch_non_temporal(txq);
> /* Perform header writes before barrier for TSO */
> otx2_nix_xmit_prepare_tso(m, flags);
> otx2_ssogws_order(ws, !ev->sched_type);
> diff --git a/drivers/event/octeontx2/otx2_worker_dual.c b/drivers/event/octeontx2/otx2_worker_dual.c
> index ff68472ef..7016eee4a 100644
> --- a/drivers/event/octeontx2/otx2_worker_dual.c
> +++ b/drivers/event/octeontx2/otx2_worker_dual.c
> @@ -148,6 +148,7 @@ otx2_ssogws_dual_deq_ ##name(void *port, struct rte_event *ev, \
> struct otx2_ssogws_dual *ws = port; \
> uint8_t gw; \
> \
> + rte_prefetch_non_temporal(ws); \
> RTE_SET_USED(timeout_ticks); \
> if (ws->swtag_req) { \
> otx2_ssogws_swtag_wait((struct otx2_ssogws *) \
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-31 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 16:07 [dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data pbhagavatula
2019-10-31 10:50 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).