From: Somnath Kotur <somnath.kotur@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH 16/16] net/bnxt: fix a possible memory leak
Date: Thu, 24 Oct 2019 11:29:11 +0530 [thread overview]
Message-ID: <20191024055913.28817-17-somnath.kotur@broadcom.com> (raw)
In-Reply-To: <20191024055913.28817-1-somnath.kotur@broadcom.com>
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
During hot fw upgrade or error recovery, driver does cleanup and
reallocation of resources. But driver reallocates memory for ring
group info table without freeing the allocated memory during
device init.
Fix this memory leak by moving the freeing of ring group info table
to bnxt_free_mem() in bnxt_uninit_resources().
Fixes: 4617e2125c7f ("net/bnxt: refactor init and uninit functions")
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 013b968..9642796 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -183,6 +183,9 @@ static void bnxt_free_mem(struct bnxt *bp, bool reconfig)
}
bnxt_free_async_cp_ring(bp);
bnxt_free_rxtx_nq_ring(bp);
+
+ rte_free(bp->grp_info);
+ bp->grp_info = NULL;
}
static int bnxt_alloc_mem(struct bnxt *bp, bool reconfig)
@@ -4821,11 +4824,6 @@ static int bnxt_init_resources(struct bnxt *bp, bool reconfig_dev)
rc = bnxt_uninit_resources(bp, false);
- if (bp->grp_info != NULL) {
- rte_free(bp->grp_info);
- bp->grp_info = NULL;
- }
-
if (bp->tx_mem_zone) {
rte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);
bp->tx_mem_zone = NULL;
--
1.8.3.1
next prev parent reply other threads:[~2019-10-24 6:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 5:58 [dpdk-dev] [PATCH 00/18] bnxt patchset with bug fixes Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 01/16] net/bnxt: fix unused value in free filter mem Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 02/16] net/bnxt: fix ping failure with MTU change Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 03/16] net/bnxt: fix to set MAX RSS contexts for maximal reservation Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 04/16] net/bnxt: fix to write the correct MTU to FW Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 05/16] net/bnxt: fix RSS configuration failure for thor-based controllers Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 06/16] net/bnxt: update HWRM API to version 1.10.1.6 Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 07/16] net/bnxt: use mac index, while checking for default mac Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 08/16] net/bnxt: fix a possible race between start and interrupt handler Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 09/16] net/bnxt: fix to use HWRM_CFA_L2_FILTER as the filter_type for non-ntuple flows Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 10/16] net/bnxt: expose some missing counters in port statistics Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 11/16] net/bnxt: fix to check for zero mac address while parsing flow arguments Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 12/16] net/bnxt: fix segfault after removing and adding the slaves Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 13/16] net/bnxt: add more checks for fw reset Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 14/16] net/bnxt: add PCI IDs for 57500 series NPAR devices Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 15/16] net/bnxt: add a wrapper function for thor device check Somnath Kotur
2019-10-24 5:59 ` Somnath Kotur [this message]
2019-10-24 5:59 ` [dpdk-dev] [PATCH 17/17] net/bnxt: fix mbuf free when clearing Tx queue Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 18/18] net/bnxt: call bnxt_uninit_locks from bnxt_uninit_resources Somnath Kotur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024055913.28817-17-somnath.kotur@broadcom.com \
--to=somnath.kotur@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).