From: Somnath Kotur <somnath.kotur@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: [dpdk-dev] [PATCH 17/17] net/bnxt: fix mbuf free when clearing Tx queue
Date: Thu, 24 Oct 2019 11:29:12 +0530 [thread overview]
Message-ID: <20191024055913.28817-18-somnath.kotur@broadcom.com> (raw)
In-Reply-To: <20191024055913.28817-1-somnath.kotur@broadcom.com>
From: Lance Richardson <lance.richardson@broadcom.com>
When freeing pending transmit mbufs, use rte_pktmbuf_free_seg()
instead of rte_pktmbuf_free(), otherwise linked mbufs may be freed
more than once.
Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_txq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c
index ebb9199..6b866d4 100644
--- a/drivers/net/bnxt/bnxt_txq.c
+++ b/drivers/net/bnxt/bnxt_txq.c
@@ -34,7 +34,7 @@ static void bnxt_tx_queue_release_mbufs(struct bnxt_tx_queue *txq)
if (sw_ring) {
for (i = 0; i < txq->tx_ring->tx_ring_struct->ring_size; i++) {
if (sw_ring[i].mbuf) {
- rte_pktmbuf_free(sw_ring[i].mbuf);
+ rte_pktmbuf_free_seg(sw_ring[i].mbuf);
sw_ring[i].mbuf = NULL;
}
}
--
2.10.1.613.g2cc2e70
next prev parent reply other threads:[~2019-10-24 6:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 5:58 [dpdk-dev] [PATCH 00/18] bnxt patchset with bug fixes Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 01/16] net/bnxt: fix unused value in free filter mem Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 02/16] net/bnxt: fix ping failure with MTU change Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 03/16] net/bnxt: fix to set MAX RSS contexts for maximal reservation Somnath Kotur
2019-10-24 5:58 ` [dpdk-dev] [PATCH 04/16] net/bnxt: fix to write the correct MTU to FW Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 05/16] net/bnxt: fix RSS configuration failure for thor-based controllers Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 06/16] net/bnxt: update HWRM API to version 1.10.1.6 Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 07/16] net/bnxt: use mac index, while checking for default mac Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 08/16] net/bnxt: fix a possible race between start and interrupt handler Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 09/16] net/bnxt: fix to use HWRM_CFA_L2_FILTER as the filter_type for non-ntuple flows Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 10/16] net/bnxt: expose some missing counters in port statistics Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 11/16] net/bnxt: fix to check for zero mac address while parsing flow arguments Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 12/16] net/bnxt: fix segfault after removing and adding the slaves Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 13/16] net/bnxt: add more checks for fw reset Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 14/16] net/bnxt: add PCI IDs for 57500 series NPAR devices Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 15/16] net/bnxt: add a wrapper function for thor device check Somnath Kotur
2019-10-24 5:59 ` [dpdk-dev] [PATCH 16/16] net/bnxt: fix a possible memory leak Somnath Kotur
2019-10-24 5:59 ` Somnath Kotur [this message]
2019-10-24 5:59 ` [dpdk-dev] [PATCH 18/18] net/bnxt: call bnxt_uninit_locks from bnxt_uninit_resources Somnath Kotur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024055913.28817-18-somnath.kotur@broadcom.com \
--to=somnath.kotur@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).