From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52B5EA32A1 for ; Thu, 24 Oct 2019 08:07:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2EBA1C1D9; Thu, 24 Oct 2019 08:07:14 +0200 (CEST) Received: from relay.smtp.broadcom.com (unknown [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 408291C029 for ; Thu, 24 Oct 2019 08:06:58 +0200 (CEST) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55]) by relay.smtp.broadcom.com (Postfix) with ESMTP id 5791B28FA8A; Wed, 23 Oct 2019 23:06:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 5791B28FA8A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1571897217; bh=a5f/NnGBKwFzFHH3y4Mrzk3tXNKYe+xCeBhs3ve5Yjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OnIn2EjxxFzCkXgslm3AVZUMhPWxhRdvSE8DGMq/RX86QO3Q/L38J4Q8qLs4KAouG 106Yse9YbWP4sG5WSXHgxlBL3+PDgEm6Ycd/Mb5lNdjb34qAg9MImjc5wgy3nYhxCN MzpXBKpvT99vgJe8T6VyBuBX1Ky3J+P9BxTDzatU= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Thu, 24 Oct 2019 11:29:00 +0530 Message-Id: <20191024055913.28817-6-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.10.1.613.g2cc2e70 In-Reply-To: <20191024055913.28817-1-somnath.kotur@broadcom.com> References: <20191024055913.28817-1-somnath.kotur@broadcom.com> Subject: [dpdk-dev] [PATCH 05/16] net/bnxt: fix RSS configuration failure for thor-based controllers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Santoshkumar Karanappa Rastapur rss_table structure stores receive, completion ring IDs for Thor based controllers and receive queue id for others. Below commit accidentally left the old code and hence was always overwriting receive ring id with queue id for Thor. This causes subsequent VNIC_RSS_CFG command to fail. Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers") Signed-off-by: Santoshkumar Karanappa Rastapur Reviewed-by: Kalesh Anakkur Purayil Reviewed-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index c97fcac..ce3a03a 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1322,9 +1322,6 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev, vnic->rss_table[i] = vnic->fw_grp_ids[reta_conf[idx].reta[sft]]; } - - vnic->rss_table[i] = - vnic->fw_grp_ids[reta_conf[idx].reta[sft]]; } bnxt_hwrm_vnic_rss_cfg(bp, vnic); -- 1.8.3.1