DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Yahui Cao <yahui.cao@intel.com>
Cc: Qiming Yang <qiming.yang@intel.com>,
	Wenzhuo Lu <wenzhuo.lu@intel.com>,
	dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue
Date: Thu, 24 Oct 2019 14:07:36 +0800	[thread overview]
Message-ID: <20191024060736.GI72825@intel.com> (raw)
In-Reply-To: <20191024125637.10530-1-yahui.cao@intel.com>

On 10/24, Yahui Cao wrote:
>Reverse the src and dest notion, since the HW expects them to be from Tx
>perspective where as the input from user is from Rx filter view.
>
>Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy")
>
>Signed-off-by: Yahui Cao <yahui.cao@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index a85a02cd0..736ccd54e 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -1609,9 +1609,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
> 						ICE_FLTR_PTYPE_NONF_IPV4_UDP;
> 				} else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
> 					filter->input.ip.v6.src_port =
>-						udp_spec->hdr.src_port;
>-					filter->input.ip.v6.dst_port =
> 						udp_spec->hdr.dst_port;
>+					filter->input.ip.v6.dst_port =
>+						udp_spec->hdr.src_port;
> 					flow_type =
> 						ICE_FLTR_PTYPE_NONF_IPV6_UDP;
> 				}
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel.

      reply	other threads:[~2019-10-24  6:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 12:56 Yahui Cao
2019-10-24  6:07 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024060736.GI72825@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=yahui.cao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).