From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7068A32A1 for ; Thu, 24 Oct 2019 08:10:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C76141C1AD; Thu, 24 Oct 2019 08:10:51 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 3962A1C18F for ; Thu, 24 Oct 2019 08:10:50 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 23:10:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,223,1569308400"; d="scan'208";a="228388737" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2019 23:10:48 -0700 Date: Thu, 24 Oct 2019 14:07:36 +0800 From: Ye Xiaolong To: Yahui Cao Cc: Qiming Yang , Wenzhuo Lu , dev@dpdk.org, Qi Zhang Message-ID: <20191024060736.GI72825@intel.com> References: <20191024125637.10530-1-yahui.cao@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024125637.10530-1-yahui.cao@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/24, Yahui Cao wrote: >Reverse the src and dest notion, since the HW expects them to be from Tx >perspective where as the input from user is from Rx filter view. > >Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy") > >Signed-off-by: Yahui Cao >--- > drivers/net/ice/ice_fdir_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c >index a85a02cd0..736ccd54e 100644 >--- a/drivers/net/ice/ice_fdir_filter.c >+++ b/drivers/net/ice/ice_fdir_filter.c >@@ -1609,9 +1609,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad, > ICE_FLTR_PTYPE_NONF_IPV4_UDP; > } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) { > filter->input.ip.v6.src_port = >- udp_spec->hdr.src_port; >- filter->input.ip.v6.dst_port = > udp_spec->hdr.dst_port; >+ filter->input.ip.v6.dst_port = >+ udp_spec->hdr.src_port; > flow_type = > ICE_FLTR_PTYPE_NONF_IPV6_UDP; > } >-- >2.17.1 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel.