DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Congwen Zhang <zhang.congwen@zte.com.cn>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix rss_conf sizeof argument
Date: Thu, 24 Oct 2019 15:44:56 +0800	[thread overview]
Message-ID: <20191024074456.GM72825@intel.com> (raw)
In-Reply-To: <1565166705-4710-1-git-send-email-zhang.congwen@zte.com.cn>

On 08/07, Congwen Zhang wrote:
>The type of rss_conf is struct igb_rte_flow_rss_conf *,
> not struct rte_eth_rss_conf *.
>
>Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/e1000/igb_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
>index 4e0b38f..0d2703d 100644
>--- a/drivers/net/e1000/igb_flow.c
>+++ b/drivers/net/e1000/igb_flow.c
>@@ -1374,7 +1374,7 @@
> 	index++;
> 	NEXT_ITEM_OF_ACTION(act, actions, index);
> 	if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>-		memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+		memset(rss_conf, 0, sizeof(struct igb_rte_flow_rss_conf));
> 		rte_flow_error_set(error, EINVAL,
> 			RTE_FLOW_ERROR_TYPE_ACTION,
> 			act, "Not supported action.");
>-- 
>1.8.3.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

      reply	other threads:[~2019-10-24  7:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-07  8:31 Congwen Zhang
2019-10-24  7:44 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024074456.GM72825@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    --cc=zhang.congwen@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).