From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 708EDA32A1 for ; Thu, 24 Oct 2019 09:48:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 476FE1D178; Thu, 24 Oct 2019 09:48:26 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 134021D161; Thu, 24 Oct 2019 09:48:24 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 00:48:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,224,1569308400"; d="scan'208";a="188510837" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga007.jf.intel.com with ESMTP; 24 Oct 2019 00:48:08 -0700 Date: Thu, 24 Oct 2019 15:44:56 +0800 From: Ye Xiaolong To: Congwen Zhang Cc: wenzhuo.lu@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20191024074456.GM72825@intel.com> References: <1565166705-4710-1-git-send-email-zhang.congwen@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565166705-4710-1-git-send-email-zhang.congwen@zte.com.cn> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/e1000: fix rss_conf sizeof argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/07, Congwen Zhang wrote: >The type of rss_conf is struct igb_rte_flow_rss_conf *, > not struct rte_eth_rss_conf *. > >Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API") > >Signed-off-by: Congwen Zhang >--- > drivers/net/e1000/igb_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c >index 4e0b38f..0d2703d 100644 >--- a/drivers/net/e1000/igb_flow.c >+++ b/drivers/net/e1000/igb_flow.c >@@ -1374,7 +1374,7 @@ > index++; > NEXT_ITEM_OF_ACTION(act, actions, index); > if (act->type != RTE_FLOW_ACTION_TYPE_END) { >- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); >+ memset(rss_conf, 0, sizeof(struct igb_rte_flow_rss_conf)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > act, "Not supported action."); >-- >1.8.3.1 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.