* [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue
@ 2019-10-24 12:56 Yahui Cao
2019-10-24 6:07 ` Ye Xiaolong
0 siblings, 1 reply; 2+ messages in thread
From: Yahui Cao @ 2019-10-24 12:56 UTC (permalink / raw)
To: Qiming Yang, Wenzhuo Lu; +Cc: dev, Qi Zhang, Yahui Cao
Reverse the src and dest notion, since the HW expects them to be from Tx
perspective where as the input from user is from Rx filter view.
Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy")
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index a85a02cd0..736ccd54e 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -1609,9 +1609,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
ICE_FLTR_PTYPE_NONF_IPV4_UDP;
} else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
filter->input.ip.v6.src_port =
- udp_spec->hdr.src_port;
- filter->input.ip.v6.dst_port =
udp_spec->hdr.dst_port;
+ filter->input.ip.v6.dst_port =
+ udp_spec->hdr.src_port;
flow_type =
ICE_FLTR_PTYPE_NONF_IPV6_UDP;
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue
2019-10-24 12:56 [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue Yahui Cao
@ 2019-10-24 6:07 ` Ye Xiaolong
0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2019-10-24 6:07 UTC (permalink / raw)
To: Yahui Cao; +Cc: Qiming Yang, Wenzhuo Lu, dev, Qi Zhang
On 10/24, Yahui Cao wrote:
>Reverse the src and dest notion, since the HW expects them to be from Tx
>perspective where as the input from user is from Rx filter view.
>
>Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy")
>
>Signed-off-by: Yahui Cao <yahui.cao@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index a85a02cd0..736ccd54e 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -1609,9 +1609,9 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,
> ICE_FLTR_PTYPE_NONF_IPV4_UDP;
> } else if (l3 == RTE_FLOW_ITEM_TYPE_IPV6) {
> filter->input.ip.v6.src_port =
>- udp_spec->hdr.src_port;
>- filter->input.ip.v6.dst_port =
> udp_spec->hdr.dst_port;
>+ filter->input.ip.v6.dst_port =
>+ udp_spec->hdr.src_port;
> flow_type =
> ICE_FLTR_PTYPE_NONF_IPV6_UDP;
> }
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-24 6:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 12:56 [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue Yahui Cao
2019-10-24 6:07 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).