From: Marvin Liu <yong.liu@intel.com>
To: maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com, amorenoz@redhat.com
Cc: dev@dpdk.org, Marvin Liu <yong.liu@intel.com>
Subject: [dpdk-dev] [PATCH] vhost: fix vhost user virtqueue not accessable
Date: Sat, 26 Oct 2019 00:20:42 +0800 [thread overview]
Message-ID: <20191025162042.71687-1-yong.liu@intel.com> (raw)
Log feature is disabled in vhost user, so that log address was invalid
when checking. Add feature bit check can skip useless address check.
Fixes: 04cfc7fdbfca ("vhost: translate incoming log address to gpa")
Signed-off-by: Marvin Liu <yong.liu@intel.com>
---
lib/librte_vhost/vhost_user.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index 61ef699ac..0407fdc29 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -741,13 +741,15 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)
vq->last_avail_idx = vq->used->idx;
}
- vq->log_guest_addr =
- translate_log_addr(dev, vq, addr->log_guest_addr);
- if (vq->log_guest_addr == 0) {
- RTE_LOG(DEBUG, VHOST_CONFIG,
- "(%d) failed to map log_guest_addr .\n",
- dev->vid);
- return dev;
+ if (dev->features & (1ULL << VHOST_F_LOG_ALL)) {
+ vq->log_guest_addr =
+ translate_log_addr(dev, vq, addr->log_guest_addr);
+ if (vq->log_guest_addr == 0) {
+ RTE_LOG(DEBUG, VHOST_CONFIG,
+ "(%d) failed to map log_guest_addr .\n",
+ dev->vid);
+ return dev;
+ }
}
vq->access_ok = 1;
--
2.17.1
next reply other threads:[~2019-10-25 8:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 16:20 Marvin Liu [this message]
2019-10-25 12:20 ` Adrian Moreno
2019-10-28 2:13 ` Liu, Yong
2019-10-29 10:02 ` Adrian Moreno
2019-10-30 11:07 ` [dpdk-dev] [PATCH v2] vhost: fix vhost user virtqueue not accessible Marvin Liu
2019-10-30 6:58 ` Tiwei Bie
2019-10-30 14:56 ` [dpdk-dev] [PATCH v3] " Marvin Liu
2019-10-31 10:42 ` Tiwei Bie
2019-10-31 14:54 ` Liu, Yong
2019-10-31 17:47 ` Adrian Moreno
2019-11-01 7:16 ` Liu, Yong
2019-11-04 8:44 ` Adrian Moreno
2019-11-04 10:13 ` [dpdk-dev] [PATCH v4] " Marvin Liu
2019-11-04 8:47 ` Adrian Moreno
2019-11-06 20:16 ` Maxime Coquelin
2019-11-06 20:59 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025162042.71687-1-yong.liu@intel.com \
--to=yong.liu@intel.com \
--cc=amorenoz@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).