From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BE54A00B8; Mon, 28 Oct 2019 08:44:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CFC91BEF7; Mon, 28 Oct 2019 08:44:40 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 548791BEF6; Mon, 28 Oct 2019 08:44:37 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 00:44:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,239,1569308400"; d="scan'208";a="202440112" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 28 Oct 2019 00:44:35 -0700 Date: Mon, 28 Oct 2019 15:41:09 +0800 From: Ye Xiaolong To: Mesut Ali Ergin Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20191028074109.GG33024@intel.com> References: <1559583889-277418-1-git-send-email-mesut.a.ergin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1559583889-277418-1-git-send-email-mesut.a.ergin@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: Fail rte_flow MARK requests if RX func was vectorized X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sorry for missing this patch for a long time. On 06/03, Mesut Ali Ergin wrote: >Runtime requests to install an rte_flow with MARK action should fail >if the device was started and a vector RX function was already chosen >for during configuration time. > >Currently, i40e rte_flow driver would successfully install the flow >with MARK action, even when vector RX functions are in use. However, >those vector RX functions will fail to retrieve the MARK data from the >device descriptor into the mbuf. The original app installing the flow >would never know what went wrong. The function introduced in this patch >must be adjusted if/when certain vector RX functions start supporting >correct FDIR processing for MARK actions. > >Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") >Cc: stable@dpdk.org > >Signed-off-by: Mesut Ali Ergin > >v3: > - Check for support made in an function for future extensibility > - Fixes code style warnings > - CC stable w/ fix reference >v2: > - Check added to fail MARK request only if the device was started >--- Minor nit, you should put the change logs after above '---' line, then they can be ignored when git-am, fix it while merging. > drivers/net/i40e/i40e_flow.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.