From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A955DA00BE; Tue, 29 Oct 2019 18:20:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7456F1BF68; Tue, 29 Oct 2019 18:20:52 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 76B232BE5 for ; Tue, 29 Oct 2019 18:20:51 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id e11so14549168wrv.4 for ; Tue, 29 Oct 2019 10:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YtFST0lwU726WUEYk/YqKDqYT85AsbFK78xJV6Fxh1A=; b=g5BTdmCedlRUvyLSkO+Dstoev1m/DQzgsBrGk+ymAkQfosWLCKP/8uhDqEy4ESdwz5 FYVJx8x+BNS+VZyLC+vMHEkUvYmtJmFzp9825Qp0B67GdBQK/nXHwRAXNOk1WN1GRkrP KTjdh/pYpluYy4pBz+hTAE4+PFPNKjbViMEJ7rgNSwByO6HL2VQdNuwjmPRZnf/7vB5F sT70r+DkCsIR8Job7oUIzlI0ulh1aar7/2CBtKQgOsI9gklD7Lizet8mtMgW2ElWBgDA VPnvYLQScxsyDwyiJlnOjpjxiX/jB/bO8xnl0L36JtdDsG3wPaDpCP9OnVQnem3szfvZ VfJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YtFST0lwU726WUEYk/YqKDqYT85AsbFK78xJV6Fxh1A=; b=DGTbopX89Rs54ZWoIYi12GwTA+hsAEBoe6rA1D+WGennJj9pgeA4g1LsCG+sXMfrLa +x4C6R39JEwcPnC9yUF08yG2VgCa9DzKwR0+J+5z+H0TwnXm3DgAUtZpsH6P5pzpyQfA RuPZrm6UsWshP+nRbRw6e5uN+51l7uB/gb3OpeLKVqWKz1o7OOMebFM0woRZtoHV613d nWKWJVYry4v1Yf1Tt4temXC2xblz3YWooKFyDo/vSpAoOsE/LAZJq2likMBovJ053vnd 1JqH7tkCLlFfn2jH0W5wVhXWe5/pmpCZy//KzU027H3HSS9C6HZs23UPqSpKGjd/qtx+ 4I5w== X-Gm-Message-State: APjAAAVtl9N18ts/+7OvEp478+GfLEHmVJrPKjUpaA0+wz01y7vLVJ3R znhaJTffc9dJ0zjtsmRlYFstMQ== X-Google-Smtp-Source: APXvYqwPqpTgXR80aN44yk3rBxL1zosOkBI8ppt3Jn5N7e8PyCPEM0/DPaYt28j0tW3kuTOfr3GPAA== X-Received: by 2002:adf:f452:: with SMTP id f18mr22045060wrp.264.1572369651204; Tue, 29 Oct 2019 10:20:51 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id c144sm3555028wmd.1.2019.10.29.10.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 10:20:48 -0700 (PDT) Date: Tue, 29 Oct 2019 18:20:47 +0100 From: Olivier Matz To: Andrew Rybchenko Cc: dev@dpdk.org, Anatoly Burakov , Ferruh Yigit , "Giridharan, Ganesan" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Stephen Hemminger , Thomas Monjalon , Vamsi Krishna Attunuru Message-ID: <20191029172047.lzxzkreoucvagtdy@platinum> References: <20190719133845.32432-1-olivier.matz@6wind.com> <20191028140122.9592-1-olivier.matz@6wind.com> <20191028140122.9592-5-olivier.matz@6wind.com> <67618332-fac8-eac1-ea66-24ed8a4b5c93@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67618332-fac8-eac1-ea66-24ed8a4b5c93@solarflare.com> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > On 10/28/19 5:01 PM, Olivier Matz wrote: > > In rte_mempool_populate_default(), we determine the page size, > > which is needed for calc_size and allocation of memory. > > > > Move this in a function and export it, it will be used in next > > commit. > > > > Signed-off-by: Olivier Matz > > One question below: > Reviewed-by: Andrew Rybchenko > > [snip] > > > diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map > > index 17cbca460..4eff2767d 100644 > > --- a/lib/librte_mempool/rte_mempool_version.map > > +++ b/lib/librte_mempool/rte_mempool_version.map > > @@ -56,5 +56,6 @@ DPDK_18.05 { > > EXPERIMENTAL { > > global: > > + rte_mempool_get_page_size; > > rte_mempool_ops_get_info; > > }; > > Should internal function be here? > Good question. Let me ask a friend ;)