* [dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4
@ 2019-10-31 10:38 Yahui Cao
2019-10-31 2:54 ` Ye Xiaolong
2019-10-31 11:22 ` [dpdk-dev] [PATCH v2] " Yahui Cao
0 siblings, 2 replies; 5+ messages in thread
From: Yahui Cao @ 2019-10-31 10:38 UTC (permalink / raw)
To: Qiming Yang, Wenzhuo Lu; +Cc: dev, Qi Zhang, Yahui Cao
Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index 736ccd54e..d80dafa20 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -128,10 +128,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},
{pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
- {pattern_eth_ipv4_gtpu_ipv4_tcp,
- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
- {pattern_eth_ipv4_gtpu_ipv4_udp,
- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
};
static struct ice_flow_parser ice_fdir_parser_os;
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4
2019-10-31 10:38 [dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4 Yahui Cao
@ 2019-10-31 2:54 ` Ye Xiaolong
2019-10-31 11:22 ` [dpdk-dev] [PATCH v2] " Yahui Cao
1 sibling, 0 replies; 5+ messages in thread
From: Ye Xiaolong @ 2019-10-31 2:54 UTC (permalink / raw)
To: Yahui Cao; +Cc: Qiming Yang, Wenzhuo Lu, dev, Qi Zhang
Hi, yahui
Prefer to give more details like why we need this patch in commit log.
Thanks,
Xiaolong
On 10/31, Yahui Cao wrote:
>Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
>
>Signed-off-by: Yahui Cao <yahui.cao@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index 736ccd54e..d80dafa20 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -128,10 +128,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
> {pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
> ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},
> {pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
>- {pattern_eth_ipv4_gtpu_ipv4_tcp,
>- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
>- {pattern_eth_ipv4_gtpu_ipv4_udp,
>- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
> };
>
> static struct ice_flow_parser ice_fdir_parser_os;
>--
>2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] net/ice: remove GTPU tunnel support for inner L4
2019-10-31 10:38 [dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4 Yahui Cao
2019-10-31 2:54 ` Ye Xiaolong
@ 2019-10-31 11:22 ` Yahui Cao
2019-10-31 13:05 ` [dpdk-dev] [PATCH v3] " Yahui Cao
1 sibling, 1 reply; 5+ messages in thread
From: Yahui Cao @ 2019-10-31 11:22 UTC (permalink / raw)
To: Qiming Yang, Wenzhuo Lu; +Cc: dev, Qi Zhang, Yahui Cao, Xiaolong Ye
Currently, share code only support inner L3 matching.
Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index 736ccd54e..2e8570f16 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -66,15 +66,6 @@
#define ICE_FDIR_INSET_GTPU_IPV4 (\
ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
-#define ICE_FDIR_INSET_GTPU_IPV4_TCP (\
- ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
- ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
- ICE_FDIR_INSET_GTPU_IPV4)
-
static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
{pattern_eth_ipv4, ICE_FDIR_INSET_ETH_IPV4, ICE_INSET_NONE},
{pattern_eth_ipv4_udp, ICE_FDIR_INSET_ETH_IPV4_UDP, ICE_INSET_NONE},
@@ -128,10 +119,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},
{pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
- {pattern_eth_ipv4_gtpu_ipv4_tcp,
- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
- {pattern_eth_ipv4_gtpu_ipv4_udp,
- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
};
static struct ice_flow_parser ice_fdir_parser_os;
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v3] net/ice: remove GTPU tunnel support for inner L4
2019-10-31 11:22 ` [dpdk-dev] [PATCH v2] " Yahui Cao
@ 2019-10-31 13:05 ` Yahui Cao
2019-11-01 2:13 ` Ye Xiaolong
0 siblings, 1 reply; 5+ messages in thread
From: Yahui Cao @ 2019-10-31 13:05 UTC (permalink / raw)
To: Qiming Yang, Wenzhuo Lu; +Cc: dev, Qi Zhang, Yahui Cao, Xiaolong Ye
Remove unsupported flow as title.
Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index 736ccd54e..2e8570f16 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -66,15 +66,6 @@
#define ICE_FDIR_INSET_GTPU_IPV4 (\
ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
-#define ICE_FDIR_INSET_GTPU_IPV4_TCP (\
- ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
- ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
- ICE_FDIR_INSET_GTPU_IPV4)
-
static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
{pattern_eth_ipv4, ICE_FDIR_INSET_ETH_IPV4, ICE_INSET_NONE},
{pattern_eth_ipv4_udp, ICE_FDIR_INSET_ETH_IPV4_UDP, ICE_INSET_NONE},
@@ -128,10 +119,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},
{pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
- {pattern_eth_ipv4_gtpu_ipv4_tcp,
- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
- {pattern_eth_ipv4_gtpu_ipv4_udp,
- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
};
static struct ice_flow_parser ice_fdir_parser_os;
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/ice: remove GTPU tunnel support for inner L4
2019-10-31 13:05 ` [dpdk-dev] [PATCH v3] " Yahui Cao
@ 2019-11-01 2:13 ` Ye Xiaolong
0 siblings, 0 replies; 5+ messages in thread
From: Ye Xiaolong @ 2019-11-01 2:13 UTC (permalink / raw)
To: Yahui Cao; +Cc: Qiming Yang, Wenzhuo Lu, dev, Qi Zhang
On 10/31, Yahui Cao wrote:
>Remove unsupported flow as title.
>
>Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
>
>Signed-off-by: Yahui Cao <yahui.cao@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index 736ccd54e..2e8570f16 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -66,15 +66,6 @@
> #define ICE_FDIR_INSET_GTPU_IPV4 (\
> ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
>
>-#define ICE_FDIR_INSET_GTPU_IPV4_TCP (\
>- ICE_FDIR_INSET_GTPU_IPV4)
>-
>-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
>- ICE_FDIR_INSET_GTPU_IPV4)
>-
>-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
>- ICE_FDIR_INSET_GTPU_IPV4)
>-
> static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
> {pattern_eth_ipv4, ICE_FDIR_INSET_ETH_IPV4, ICE_INSET_NONE},
> {pattern_eth_ipv4_udp, ICE_FDIR_INSET_ETH_IPV4_UDP, ICE_INSET_NONE},
>@@ -128,10 +119,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
> {pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
> ICE_FDIR_INSET_VXLAN_IPV4_SCTP, ICE_INSET_NONE},
> {pattern_eth_ipv4_gtpu_ipv4, ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
>- {pattern_eth_ipv4_gtpu_ipv4_tcp,
>- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
>- {pattern_eth_ipv4_gtpu_ipv4_udp,
>- ICE_FDIR_INSET_GTPU_IPV4, ICE_INSET_NONE},
> };
>
> static struct ice_flow_parser ice_fdir_parser_os;
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-01 2:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 10:38 [dpdk-dev] [PATCH] net/ice: remove GTPU tunnel support for inner L4 Yahui Cao
2019-10-31 2:54 ` Ye Xiaolong
2019-10-31 11:22 ` [dpdk-dev] [PATCH v2] " Yahui Cao
2019-10-31 13:05 ` [dpdk-dev] [PATCH v3] " Yahui Cao
2019-11-01 2:13 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).