From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F58CA04A3; Mon, 4 Nov 2019 04:23:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DD035F13; Mon, 4 Nov 2019 04:22:59 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3151C4CA7 for ; Mon, 4 Nov 2019 04:22:58 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 19:22:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="213401101" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga002.jf.intel.com with ESMTP; 03 Nov 2019 19:22:56 -0800 Date: Mon, 4 Nov 2019 11:19:05 +0800 From: Ye Xiaolong To: Qi Zhang Cc: qiming.yang@intel.com, dev@dpdk.org Message-ID: <20191104031905.GT11315@intel.com> References: <20191031035521.45015-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031035521.45015-1-qi.z.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice/base: fix wrong symmetric hash configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31, Qi Zhang wrote: >When a new hash profie is created, we need to reset all related >GLQF_HSYMM registers, otherwise unexpected hash behaviour may happens >on packet that hit that profile. > >The patch fix the issue that we only do reset when symmetric hash >is required, but actually for non symmmetric hash we also need this, >since GLQF_HSYMM might be polluted by previous configuration. > >Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS") > >Signed-off-by: Qi Zhang >Tested-by: Simei Su >--- > drivers/net/ice/base/ice_flow.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c >index d2dbb1177..797d7e6e6 100644 >--- a/drivers/net/ice/base/ice_flow.c >+++ b/drivers/net/ice/base/ice_flow.c >@@ -2199,8 +2199,6 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds, > status = ice_add_rss_list(hw, vsi_handle, prof); > > prof->cfg.symm = symm; >- if (!symm) >- goto exit; > > update_symm: > ice_rss_update_symm(hw, prof); >-- >2.13.6 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.