From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
Pallantla Poornima <pallantlax.poornima@intel.com>
Subject: [dpdk-dev] [PATCH] test/mempool: fix false positive test result
Date: Mon, 4 Nov 2019 11:06:23 +0100 [thread overview]
Message-ID: <20191104100622.13048-1-olivier.matz@6wind.com> (raw)
The ret variable, initialized to -1, is changed to 0 during the test,
making the test successful in some cases where it should return a
failure.
Fix this by always using the GOTO_ERR() macro that sets the ret
variable before doing the goto.
Fixes: 923ceaeac140 ("test/mempool: add unit test cases")
Cc: Pallantla Poornima <pallantlax.poornima@intel.com>
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
app/test/test_mempool.c | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 8b20886c8..c32a5d387 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -502,7 +502,7 @@ test_mempool(void)
if (mp_nocache == NULL) {
printf("cannot allocate mp_nocache mempool\n");
- goto err;
+ GOTO_ERR(ret, err);
}
/* create a mempool (with cache) */
@@ -515,7 +515,7 @@ test_mempool(void)
if (mp_cache == NULL) {
printf("cannot allocate mp_cache mempool\n");
- goto err;
+ GOTO_ERR(ret, err);
}
/* create an empty mempool */
@@ -571,15 +571,15 @@ test_mempool(void)
if (mp_stack == NULL) {
printf("cannot allocate mp_stack mempool\n");
- goto err;
+ GOTO_ERR(ret, err);
}
if (rte_mempool_set_ops_byname(mp_stack, "stack", NULL) < 0) {
printf("cannot set stack handler\n");
- goto err;
+ GOTO_ERR(ret, err);
}
if (rte_mempool_populate_default(mp_stack) < 0) {
printf("cannot populate mp_stack mempool\n");
- goto err;
+ GOTO_ERR(ret, err);
}
rte_mempool_obj_iter(mp_stack, my_obj_init, NULL);
@@ -593,23 +593,23 @@ test_mempool(void)
if (default_pool == NULL) {
printf("cannot allocate default mempool\n");
- goto err;
+ GOTO_ERR(ret, err);
}
if (rte_mempool_set_ops_byname(default_pool,
default_pool_ops, NULL) < 0) {
printf("cannot set %s handler\n", default_pool_ops);
- goto err;
+ GOTO_ERR(ret, err);
}
if (rte_mempool_populate_default(default_pool) < 0) {
printf("cannot populate %s mempool\n", default_pool_ops);
- goto err;
+ GOTO_ERR(ret, err);
}
rte_mempool_obj_iter(default_pool, my_obj_init, NULL);
/* retrieve the mempool from its name */
if (rte_mempool_lookup("test_nocache") != mp_nocache) {
printf("Cannot lookup mempool from its name\n");
- goto err;
+ GOTO_ERR(ret, err);
}
printf("Walk into mempools:\n");
@@ -619,36 +619,36 @@ test_mempool(void)
/* basic tests without cache */
if (test_mempool_basic(mp_nocache, 0) < 0)
- goto err;
+ GOTO_ERR(ret, err);
/* basic tests with cache */
if (test_mempool_basic(mp_cache, 0) < 0)
- goto err;
+ GOTO_ERR(ret, err);
/* basic tests with user-owned cache */
if (test_mempool_basic(mp_nocache, 1) < 0)
- goto err;
+ GOTO_ERR(ret, err);
/* more basic tests without cache */
if (test_mempool_basic_ex(mp_nocache) < 0)
- goto err;
+ GOTO_ERR(ret, err);
/* mempool operation test based on single producer and single comsumer */
if (test_mempool_sp_sc() < 0)
- goto err;
+ GOTO_ERR(ret, err);
if (test_mempool_creation_with_exceeded_cache_size() < 0)
- goto err;
+ GOTO_ERR(ret, err);
if (test_mempool_same_name_twice_creation() < 0)
- goto err;
+ GOTO_ERR(ret, err);
/* test the stack handler */
if (test_mempool_basic(mp_stack, 1) < 0)
- goto err;
+ GOTO_ERR(ret, err);
if (test_mempool_basic(default_pool, 1) < 0)
- goto err;
+ GOTO_ERR(ret, err);
rte_mempool_list_dump(stdout);
--
2.20.1
next reply other threads:[~2019-11-04 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 10:06 Olivier Matz [this message]
2019-11-04 12:42 ` Andrew Rybchenko
2019-11-06 10:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104100622.13048-1-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=pallantlax.poornima@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).