DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com,
	Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-dev] [PATCH v3 3/5] net/bnxt: fix vnic allocation failure on port toggle
Date: Mon,  4 Nov 2019 14:50:24 -0800	[thread overview]
Message-ID: <20191104225026.97569-4-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20191104225026.97569-1-ajit.khaparde@broadcom.com>

From: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>

bnxt_init_chip called on port start keeps incrementing rx_cosq_cnt.
Hence more vnics are allocated with less number of rings on each port
stop/start operation. Eventually vnic allocation fails due to incorrect
ring group as no ring gets allocated to the vnic.

Fixes: 84d49664b5b2 ("net/bnxt: support CoS classification")

Signed-off-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 0b0ce8785..3acf66d59 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -967,6 +967,7 @@ static void bnxt_dev_stop_op(struct rte_eth_dev *eth_dev)
 	bnxt_shutdown_nic(bp);
 	bnxt_hwrm_if_change(bp, 0);
 	bp->dev_stopped = 1;
+	bp->rx_cosq_cnt = 0;
 }
 
 static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
-- 
2.21.0 (Apple Git-122)


  parent reply	other threads:[~2019-11-04 22:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-04 10:02 [dpdk-dev] [PATCH v2 0/5] bnxt patchset with bug fixes Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 1/5] net/bnxt: fix L4 checksum error indication in non-vector mode rx Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 2/5] net/bnxt: fix redundant mac addr check Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 3/5] net/bnxt: fix vnic allocation failure on port toggle Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 4/5] net/bnxt: fix a failure case during initialization Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 5/5] net/bnxt: fix incorrect COS queue mapping Kalesh A P
2019-11-04 22:50 ` [dpdk-dev] [PATCH v3 0/5] bnxt patchset with bug fixes Ajit Khaparde
2019-11-04 22:50   ` [dpdk-dev] [PATCH v3 1/5] net/bnxt: fix L4 checksum indication in non-vector Rx Ajit Khaparde
2019-11-04 22:50   ` [dpdk-dev] [PATCH v3 2/5] net/bnxt: fix redundant MAC address check Ajit Khaparde
2019-11-04 22:50   ` Ajit Khaparde [this message]
2019-11-04 22:50   ` [dpdk-dev] [PATCH v3 4/5] net/bnxt: fix a failure case during initialization Ajit Khaparde
2019-11-04 22:50   ` [dpdk-dev] [PATCH v3 5/5] net/bnxt: fix incorrect COS queue mapping Ajit Khaparde
2019-11-04 23:12   ` [dpdk-dev] [PATCH v3 0/5] bnxt patchset with bug fixes Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104225026.97569-4-ajit.khaparde@broadcom.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=santosh.rastapur@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).