From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92686A04AB; Fri, 8 Nov 2019 03:39:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C91501BF16; Fri, 8 Nov 2019 03:39:54 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 042C51BEC9 for ; Fri, 8 Nov 2019 03:39:52 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2019 18:39:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,280,1569308400"; d="scan'208";a="233486068" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga002.fm.intel.com with ESMTP; 07 Nov 2019 18:39:50 -0800 Date: Fri, 8 Nov 2019 10:35:45 +0800 From: Ye Xiaolong To: Haiyue Wang Cc: dev@dpdk.org, olivier.matz@6wind.com Message-ID: <20191108023545.GH100445@intel.com> References: <20191105011918.53434-1-haiyue.wang@intel.com> <20191107104402.99398-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107104402.99398-1-haiyue.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/07, Haiyue Wang wrote: >The original design is to use rte_mbuf::udata64 to save the metadata of >protocol extraction which has network protocol data fields and type, a >private API is used to decode this metadata. > >Use the dynamic mbuf field and flags to register the needed fields in >mbuf, to avoid overwriting 'rte_mbuf::udata64' if the application uses >it. It only needs 4B size to save the protocol extraction data, and its >type and validity is indicated by related bit in 'rte_mbuf::ol_flags'. > >Signed-off-by: Haiyue Wang >--- >v9: - Rename the dynamic filed and flags variables to _offs, _mask, so it > matches the design. > >v8: - Cleanup the doxgen, rename the dynamic filed and flags with ice prefix. > >v7: - Change the log level from ERR to DEBUG for a successful registration, > ERR is used to develop firstly. > >v6: - Don't need to register all flags when if one dev_args is set, register > it as required. > >v5: - Remove the '_OL/_ol' in dynamic mbuf flag to make the variable clean. > >v4: - Include the 'rte_pmd_ice.h' header in ICE source as needed, reduce > its compile scope. > >v3: - Use the conventions name "rte_net__dynfield_" since it > is defined in a in PMD. > - Add helpers API for easiy access. > >v2: - disable the protocol extraction if failed to register some ol_flags > - rewrite the commit message > > doc/api/doxy-api-index.md | 1 + > doc/api/doxy-api.conf.in | 1 + > doc/guides/nics/ice.rst | 14 +- > drivers/net/ice/ice_ethdev.c | 84 ++++++- > drivers/net/ice/ice_ethdev.h | 9 + > drivers/net/ice/ice_rxtx.c | 88 ++++--- > drivers/net/ice/ice_rxtx.h | 1 - > drivers/net/ice/rte_pmd_ice.h | 313 +++++++++++++++--------- > drivers/net/ice/rte_pmd_ice_version.map | 12 + > 9 files changed, 370 insertions(+), 153 deletions(-) > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.