From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EB7EA04B4; Fri, 8 Nov 2019 17:16:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B41371BF57; Fri, 8 Nov 2019 17:16:06 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 3E01F1BEE1 for ; Fri, 8 Nov 2019 17:16:05 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id r4so4887981pfl.7 for ; Fri, 08 Nov 2019 08:16:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=166KuKc+4d9NpL4J5d1NRInodz4x/OrPY2NFIokDnWU=; b=zfUoE0a6aJ7UTMrs3vWmvUPMzd2jXCBwmjq6asHWXkgPCgXQO9XilsnbDFiAGtbkqL dNPou2gKo0fBZ5gsNEc9FpKUon0eFhf6a6t5nIRDEWcDX/bDUlEFW2K71t0Z96OZIGm4 wxUknZ3grSo9LcCXlbwjFl3YVJJPvR176mbgB9+cGpE3IGkh3OTBf200bfadkCMH4PVB a9VoY7U60OlQmIuQsJZcf/E/DJVihmdofeQCT4j/SvJPHYztRcSItKid3wP7QKL7RCeX teSX7E03G2Oas0jOO92BzelaTCXnHB/DBWUoZS9KWm+dh4ZxtBrr5Hwz2UN9+PSlGfIe BryQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=166KuKc+4d9NpL4J5d1NRInodz4x/OrPY2NFIokDnWU=; b=QRuRBOcEVtxOndwoog8MWxJatHzlbhVy+/qBB4IM7Xrde/yEt8N2sPj0TKn8h3tcCC nPvPpZfwOtvh5xVLddeCOkQAN+mzyC/6LK6EHc0qc9gA4KdqXtRB76goX7lwfYhATEjM oNzlsvPtHOPo/1DNgnynXaACanJrKlXyjzboDrIxH8k5hRFvjJbcc6CvOwx0PboJBw8C h7Hdq4m3lPpvI0KrtY8XyuLkkGLHXkh0NPqK3wKbFMlDbMlbPmrSX2JzLn3tuxFXlxXm 92G8RevbTOySW4Axlk6bkcdgYh/kgrq8/tQT36CA97F1H2w9kBc2MI8r0GfvwBbGMkyl FrZg== X-Gm-Message-State: APjAAAWNMJnm8zSyTrseEeZbP6FnXG1s/WejP6dN013x2yLbmnGe4FNH 5+wGLHr5CrAwU496PG5l+wA4wA== X-Google-Smtp-Source: APXvYqy+hr7HKscY9gUQwLq9JaftLpxZ/SIVVZb69Emm0bItzX08EwcwGYdbzsfjk7w32FGsNDz+Pg== X-Received: by 2002:a63:e412:: with SMTP id a18mr288453pgi.241.1573229763920; Fri, 08 Nov 2019 08:16:03 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y3sm5956219pgl.78.2019.11.08.08.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 08:16:03 -0800 (PST) Date: Fri, 8 Nov 2019 08:15:53 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Olivier Matz , dev@dpdk.org Message-ID: <20191108081553.78d1900d@hermes.lan> In-Reply-To: <20191106120943.15967-1-thomas@monjalon.net> References: <20191106120943.15967-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 6 Nov 2019 13:09:43 +0100 Thomas Monjalon wrote: > The constants like AF_INET are in sys/socket.h in FreeBSD. > The #ifdef macro __FreeBSD__ is replaced with RTE_EXEC_ENV_FREEBSD > in order to be consistent across DPDK files, and allow to grep > for EXEC_ENV among other benefits. > > Signed-off-by: Thomas Monjalon > --- > app/test-pmd/cmdline.c | 2 +- > app/test/test_cmdline_ipaddr.c | 2 +- > examples/cmdline/commands.c | 2 +- > lib/librte_cmdline/cmdline_parse_ipaddr.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 4478069911..74e02d6813 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -11,7 +11,7 @@ > #include > #include > #include > -#ifdef __FreeBSD__ > +#ifdef RTE_EXEC_ENV_FREEBSD > #include > #endif > #include > diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c > index 2d11ce936c..315ac3a9f8 100644 > --- a/app/test/test_cmdline_ipaddr.c > +++ b/app/test/test_cmdline_ipaddr.c > @@ -6,7 +6,7 @@ > #include > #include > #include > -#ifdef __FreeBSD__ > +#ifdef RTE_EXEC_ENV_FREEBSD > #include > #endif > > diff --git a/examples/cmdline/commands.c b/examples/cmdline/commands.c > index 1249ee7a8a..4badffc257 100644 > --- a/examples/cmdline/commands.c > +++ b/examples/cmdline/commands.c > @@ -12,7 +12,7 @@ > #include > #include > #include > -#ifdef __FreeBSD__ > +#ifdef RTE_EXEC_ENV_FREEBSD > #include > #endif > > diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c > index 848c1eb07d..4de5ba35ae 100644 > --- a/lib/librte_cmdline/cmdline_parse_ipaddr.c > +++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c > @@ -13,7 +13,7 @@ > #include > #include > #include > -#ifdef __FreeBSD__ > +#ifdef RTE_EXEC_ENV_FREEBSD > #include > #endif > Why not always include sys/socket.h having an extra include is much less of a nuisance than a silly #ifdef.