From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef
Date: Mon, 11 Nov 2019 10:41:33 +0000 [thread overview]
Message-ID: <20191111104133.GA1444@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191108180035.7991-1-stephen@networkplumber.org>
On Fri, Nov 08, 2019 at 10:00:35AM -0800, Stephen Hemminger wrote:
> The #ifdef to conditionally include <sys/socket.h> on BSD
> is unnecessary. It is harmless to include the header on other
> OS's. An extra include is better than an #ifdef.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> app/test-pmd/cmdline.c | 2 --
> app/test/test_cmdline_ipaddr.c | 2 --
> lib/librte_cmdline/cmdline_parse_ipaddr.c | 2 --
> 3 files changed, 6 deletions(-)
>
Seems reasonable
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2019-11-11 10:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 12:09 [dpdk-dev] [PATCH] cmdline: replace FreeBSD ifdef for IP address parsing Thomas Monjalon
2019-11-06 12:11 ` Burakov, Anatoly
2019-11-08 8:44 ` Olivier Matz
2019-11-08 10:18 ` David Marchand
2019-11-08 16:15 ` Stephen Hemminger
2019-11-08 16:28 ` Thomas Monjalon
2019-11-08 18:00 ` [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef Stephen Hemminger
2019-11-11 10:41 ` Bruce Richardson [this message]
2019-11-12 8:10 ` Olivier Matz
2019-11-12 19:14 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111104133.GA1444@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).