From: Bruce Richardson <bruce.richardson@intel.com>
To: Phil Yang <phil.yang@arm.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
jerinj@marvell.com, Honnappa.Nagarahalli@arm.com,
gavin.hu@arm.com, joyce.kong@arm.com, nd@arm.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture
Date: Mon, 11 Nov 2019 10:47:12 +0000 [thread overview]
Message-ID: <20191111104712.GB1444@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1573468461-25972-1-git-send-email-phil.yang@arm.com>
On Mon, Nov 11, 2019 at 06:34:20PM +0800, Phil Yang wrote:
> The older version (e.g. version 7.4.0 ) of GNU C compiler for the armhf
> architecture doesn't support the flag '-Wno-address-of-packed-member',
> so remove this flag for aarch32.
>
> Fixes: a385972c3675 ("mk: disable warning for packed member pointer")
> Cc: stable@dpdk.org
>
> Signed-off-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> Tested-by: Joyce Kong <joyce.kong@arm.com>
>
> ---
> mk/toolchain/gcc/rte.vars.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk
> index 9fc7041..ec0cbbf 100644
> --- a/mk/toolchain/gcc/rte.vars.mk
> +++ b/mk/toolchain/gcc/rte.vars.mk
> @@ -100,7 +100,9 @@ WERROR_FLAGS += -Wno-format-truncation
> endif
>
> # disable packed member unalign warnings
> +ifneq ($(CONFIG_RTE_ARCH_ARM), y)
> WERROR_FLAGS += -Wno-address-of-packed-member
> +endif
>
You don't need to do this, as gcc will not complain about this unknown flag
unless you have other issues in your code.[1] I think it's better to keep the
code clean in this case, otherwise we'll have the code littered with
conditionals for various flags.
/Bruce
[1] https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
"When an unrecognized warning option is requested (e.g.,
-Wunknown-warning), GCC emits a diagnostic stating that the option is not
recognized. However, if the -Wno- form is used, the behavior is slightly
different: no diagnostic is produced for -Wno-unknown-warning unless other
diagnostics are being produced. This allows the use of new -Wno- options
with old compilers, but if something goes wrong, the compiler warns that an
unrecognized option is present."
next prev parent reply other threads:[~2019-11-11 10:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 10:34 Phil Yang
2019-11-11 10:34 ` [dpdk-dev] [PATCH 2/2] doc: add aarch32 build guidance Phil Yang
2020-05-24 21:21 ` Thomas Monjalon
2020-05-25 3:20 ` Phil Yang
2020-05-27 8:28 ` Ruifeng Wang
2020-07-02 5:37 ` Phil Yang
2020-07-02 8:01 ` Jerin Jacob
2019-11-11 10:47 ` Bruce Richardson [this message]
2019-11-12 5:25 ` [dpdk-dev] [PATCH 1/2] mk: fix unsupported flag error on armhf architercture Phil Yang (Arm Technology China)
2019-11-12 6:03 ` Thomas Monjalon
2019-11-12 6:40 ` Phil Yang (Arm Technology China)
2019-11-26 17:01 ` Thomas Monjalon
2019-11-27 8:09 ` Phil Yang (Arm Technology China)
2019-11-27 9:29 ` Bruce Richardson
2019-11-27 10:00 ` Phil Yang (Arm Technology China)
2019-11-27 10:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111104712.GB1444@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).