From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C49AA04AB; Tue, 12 Nov 2019 09:29:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A9D1271; Tue, 12 Nov 2019 09:29:12 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id B4CB3A3 for ; Tue, 12 Nov 2019 09:29:10 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xAC8PmC1017702; Tue, 12 Nov 2019 00:29:09 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=pfpt0818; bh=WFdcljwYNmWR+fAHMvPIT+ocA/wKn+H/ANEpqPlFjBM=; b=VWIAp2AgcYbRoeaPd1OB+yZ9yjQyW6lhobWk45h08ZZoFu3SqM9BO2lzxKPoBXgi1+NV WgsoJ0nJk1eXQV9D7ugmiV8ogdbfUG6CWUVylory8niZi07IISSK9BX3QrW7tMEZbQ1E wX5EB2Rc5k43HALPw5coYV2E5zBJ/bia03P/Ctht332fchw8oZMKD6r9VUd9szuUwFtC 3PluKlz3ocT5cJHNIeBxdB3zcDt52O+R1UXC0f3BXZdZBvFHNHJ3yhnoM+BqbzGDLUwb VcNnrYIf5CJ8KTyQgL4BBY5dpYBpv6zYRxJbyJ4ekzd1XhUcUDhTC1f2PIOemL7ovhGT UQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2w5wurt1av-11; Tue, 12 Nov 2019 00:29:09 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 12 Nov 2019 00:26:37 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 12 Nov 2019 00:26:37 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eMZrtHA2YGkaFdD4hAyIrZd7yvPmG1GudokLf49QvDhEB+HhF8c8SRkbLX0iA2xwhb6TQoCuxlSd+OBFz7CkrIkTM6nsP0uVQys4cA49c2sbe5uykwrXnFCQ7uMVmxoDneJBjTkQztTxcJyKEF0FqmX9xyObj3/c1DdKJ3hcM2u6NRBrrM2VthTDtBvn3gVvGVUNymTw+E3Y7j4hXpa8pORRL1nORRl9hB2aiPfz3+Rq64DOhs46AFmEksMOFpA6YsS/+iOI51HW3vRgczTGXBJuhxgjgEMjSiZ9dm6ZoKXTbpSqFBImXLDqx2EMUxqQEUXSqMkiV5UBvY9IukSfsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFdcljwYNmWR+fAHMvPIT+ocA/wKn+H/ANEpqPlFjBM=; b=cK42bKVqFqXAgO02evO4HKDeJVmfslJ0Jh1bYi/2K1iB4KcJFGgMXsu1/O2qfKmJVF0OGPLVBWEsJWsyQbBaDleG2SzGiC/djKRI6WWxzUtdc433LDFqnoVTTKXkNU8vzJ7Tvla7PcqoZ793dmZDKWavP5Ol2p19CnuErxjew4sk9Rq8WgWEO5pWLpMko7mpbOafXxxevcLxi9ImG6dMhFkyuVGKSRySP2aDmfzbSPC5ZrGJ/Xgsjk6pSltVbSENW6zpEhhusTCOiIb2XFZEsJbJQyrmRUwfEjBDLYsNpjkrtygPcuMXUBmTf68brTyqAa3SQWsAJJzhWPFdPjaJGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFdcljwYNmWR+fAHMvPIT+ocA/wKn+H/ANEpqPlFjBM=; b=PNp/Thh+UgkngCPvoM6HOPYTsl3CyE2nmyz2iLu2ulwPEaYf1fbINNyJ42QIiqOLpFKtFrsn+JI+B8wTehy4Cahl+mKimyJsFUb5NxK3o6/BwXYA98CeXC8HJgskkPEmLF4N1NeKt4JpHjd9ps0tF+VYX/BCkQKpc0hG7ODWQfE= Received: from MN2PR18MB2640.namprd18.prod.outlook.com (20.179.81.96) by MN2PR18MB3213.namprd18.prod.outlook.com (10.255.238.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22; Tue, 12 Nov 2019 08:26:36 +0000 Received: from MN2PR18MB2640.namprd18.prod.outlook.com ([fe80::6c1b:feb7:a527:7583]) by MN2PR18MB2640.namprd18.prod.outlook.com ([fe80::6c1b:feb7:a527:7583%5]) with mapi id 15.20.2430.027; Tue, 12 Nov 2019 08:26:36 +0000 From: Krzysztof Kanas To: David Marchand CC: Krzysztof Kanas , dev , "Yigit, Ferruh" , Bruce Richardson Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v3 0/3] test: fix timeout in flags autotest Thread-Index: AQHVlh6Npt/G66xe2ke9bRrNymrgAqeBHJiAgAAsyYCABfAngA== Date: Tue, 12 Nov 2019 08:26:34 +0000 Message-ID: <20191112082631.GA14417@kk-box-0> References: <20191108102135.7249-1-kkanas@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [199.233.58.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb150097-2eae-4800-197f-08d7674a0852 x-ms-traffictypediagnostic: MN2PR18MB3213: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 021975AE46 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(7916004)(396003)(136003)(366004)(346002)(376002)(39860400002)(199004)(189003)(76176011)(8676002)(446003)(9686003)(14454004)(316002)(6512007)(5660300002)(86362001)(11346002)(6436002)(486006)(186003)(53546011)(6506007)(26005)(6916009)(66066001)(81166006)(71200400001)(71190400001)(2906002)(102836004)(54906003)(6486002)(1076003)(33716001)(66556008)(25786009)(4326008)(64756008)(66446008)(66476007)(81156014)(7736002)(478600001)(305945005)(99286004)(3846002)(6246003)(33656002)(66946007)(91956017)(76116006)(14444005)(256004)(8936002)(476003)(6116002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3213; H:MN2PR18MB2640.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EkjRgSOiG9IWDXnQ310DHLkQrSjB0R/0jMXRqmx0+F3AHBQR0D3aXK7prFY0KPPxa9nTNuXyxueEU4cwbuh6YiZy/Oz6HTeXcID65qMqgElgBNAfRkueEBkmF/9BNXHfWwO7pnXpd+r0Pe7jnAcRZAX+uEGW8LvcwvUSHXttmDCB6K7QbEnlDy3ZQOUcwRiVv6OcFbigRei6Lo3ZsOWhYwq7wY//UMZowiQ5RkB5y8QiziDJVziXNaA1QG7MQBhVPW/cEsaUMKvTCRUjaHbbxtiGFW0IrkQ1JVn5MZtfeBsRhXiRTtmyq0sIcopj4u5dLDg1+cnrGg1pz84YW9GneB3UwexFU5u87Bb2WIrfheT6JDG1hrDiY8jQLgDsVf64nEXrn6z1FOo4KjjdA93RhEFfUMP4mE/yLReu/JxMlE+xISuXk/ecFgibCwX2thkZ Content-Type: text/plain; charset="us-ascii" Content-ID: <42BAD67AA3370B4CAA5051777BF929ED@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bb150097-2eae-4800-197f-08d7674a0852 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2019 08:26:35.9564 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TumFd6UtFpNyAd5r0e2jViAzkNFLGSkFs9hr8S1Jli8ejTKy8Y+a9XWLavpLNxyM9rfk12UNuTs1azx5EG0OPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3213 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-11-12_02:2019-11-11,2019-11-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 0/3] test: fix timeout in flags autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19-11-08 14:45, David Marchand wrote: > External Email >=20 > ---------------------------------------------------------------------- > On Fri, Nov 8, 2019 at 12:05 PM David Marchand > wrote: > > > > On Fri, Nov 8, 2019 at 11:21 AM wrote: > > > > > > Hi David, > > > > > > Thanks for review, hopefully this patch will addresses most of the su= tff. > > > Rest I will address here. > > > > > > > > > > > > + const char *procdir =3D "/proc/self/fd/"; > > > > > > > > self is a Linux thing. > > > > This won't work on FreeBSD. > > > > > > IMHO original code didn't worked on FreeBSD as well. > > > I have created function to adress in third patch > > > > Indeed... > > > > Well, wait. > > Why do we need to close those file descriptors? > > FreeBSD has been like this for quite some time. >=20 > We don't know what this is used for. >=20 > We know it does not work on FreeBSD, but this does not seem to be a probl= em. > Introducing something more on FreeBSD is a risk with no actual benefit > at first sight. Ok. >=20 > Either we take only the first patch under a #ifdef EXEC_ENV_LINUX or > we leave this as is. I would like have that because ARM64 is main platform for me and this=20 makes the test pass, and fixes the difference between the comment and=20 the code. >=20 > Krzystof, is this a problem for you if we postpone and investigate > further for 20.02? Not a problem. I would like to have fix for EXEC_ENV_LINUX for now. =20 Rest, FreeBSD case and the decisions weather this whole code should be=20 deleted can be made later. >=20 >=20 > --=20 > David Marchand >=20 --=20 - Regards, Krzysztof(Chris) Kanas=