From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEDC6A04C1; Tue, 12 Nov 2019 15:25:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD4329E4; Tue, 12 Nov 2019 15:25:35 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id BC8662AB for ; Tue, 12 Nov 2019 15:25:33 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 06:25:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,296,1569308400"; d="scan'208";a="378893105" Received: from dpdk51.sh.intel.com ([10.67.110.245]) by orsmga005.jf.intel.com with ESMTP; 12 Nov 2019 06:25:31 -0800 From: Qi Zhang To: qiming.yang@intel.com Cc: simei.su@intel.com, dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang Date: Tue, 12 Nov 2019 22:28:36 +0800 Message-Id: <20191112142836.10210-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] net/ice: ignore error when remove RSS rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, multiple rte_flow RSS rules may mapping to the same hardware rule if a later rule is just for inputset change or symm turn on/off. so after one of the rules be destroyed, we will get error ICE_ERR_DOES_NOT_EXIST when destroying any other rules. The patch simply fix this by ignore this error. A more sophistic fix that remember the sequence and replay properly will be provided in future. Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Signed-off-by: Qi Zhang --- drivers/net/ice/ice_hash.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index d88434305..2e9c1bc67 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -536,7 +536,12 @@ ice_hash_destroy(struct ice_adapter *ad, ret = ice_rem_rss_cfg(hw, vsi->idx, filter_ptr->rss_cfg.hashed_flds, filter_ptr->rss_cfg.packet_hdr); - if (ret) { + /* Fixme: Ignore the error if a rule does not exist. + * Currently a rule for inputset change or symm turn on/off + * will overwrite an exist rule, while application still + * have 2 rte_flow handles. + **/ + if (ret && ret != ICE_ERR_DOES_NOT_EXIST) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "rss flow destroy fail"); -- 2.13.6