* [dpdk-dev] Virtio pci legacy support
@ 2019-11-12 17:23 Stephen Hemminger
2019-11-13 5:21 ` Tiwei Bie
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2019-11-12 17:23 UTC (permalink / raw)
To: Maxime Coquelin, Tiwei Bie, Ferruh Yigit; +Cc: dev
Since Linux kernel is going to drop support for iopl real soon now.
Is there any ongoing effort to either drop Legacy virtio support,
or replace iopl with ioperm, or at least test with iopl failing?
Note: it looks like the current code does not match comment.
/*
* Request iopl privilege for all RPL, returns 0 on success
* iopl() call is mostly for the i386 architecture. For other architectures,
* return -1 to indicate IO privilege can't be changed in this way.
*/
int
rte_eal_iopl_init(void)
{
#if defined(RTE_ARCH_X86)
if (iopl(3) != 0)
return -1;
#endif
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] Virtio pci legacy support
2019-11-12 17:23 [dpdk-dev] Virtio pci legacy support Stephen Hemminger
@ 2019-11-13 5:21 ` Tiwei Bie
0 siblings, 0 replies; 2+ messages in thread
From: Tiwei Bie @ 2019-11-13 5:21 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Maxime Coquelin, Ferruh Yigit, dev
On Tue, Nov 12, 2019 at 09:23:31AM -0800, Stephen Hemminger wrote:
> Since Linux kernel is going to drop support for iopl real soon now.
> Is there any ongoing effort to either drop Legacy virtio support,
I think it's not a good idea to drop the legacy virtio
support at present.
> or replace iopl with ioperm,
+1. This looks like the most straightforward way for now.
> or at least test with iopl failing?
The iopl failing test was just moved to rte_pci_ioport_map()
by below series:
https://patches.dpdk.org/cover/61627/
>
> Note: it looks like the current code does not match comment.
>
> /*
> * Request iopl privilege for all RPL, returns 0 on success
> * iopl() call is mostly for the i386 architecture. For other architectures,
> * return -1 to indicate IO privilege can't be changed in this way.
> */
> int
> rte_eal_iopl_init(void)
> {
> #if defined(RTE_ARCH_X86)
> if (iopl(3) != 0)
> return -1;
> #endif
> return 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-13 5:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 17:23 [dpdk-dev] Virtio pci legacy support Stephen Hemminger
2019-11-13 5:21 ` Tiwei Bie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).