From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A37C5A04C1; Fri, 22 Nov 2019 12:30:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E41B51DBC; Fri, 22 Nov 2019 12:30:29 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3C755374; Fri, 22 Nov 2019 12:30:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Nov 2019 03:30:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,229,1571727600"; d="scan'208";a="407545998" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.223.78]) by fmsmga005.fm.intel.com with ESMTP; 22 Nov 2019 03:30:25 -0800 From: Ferruh Yigit To: Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org, stable@dpdk.org, Bruce Richardson Date: Fri, 22 Nov 2019 11:30:23 +0000 Message-Id: <20191122113023.15296-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191112131556.16668-1-ferruh.yigit@intel.com> References: <20191112131556.16668-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] mk: remove library search path from binary X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch functionally reverts the patch in fixes line to not have any hardcoded library path in the final binary for the security reasons, in case this binary distributed to production environment. RPATH only added in RTE_DEVEL_BUILD case and this binary shouldn't distributed, but still removing it to be cautious. Fixes: 8919f73bcbaa ("mk: add build directory to library search path") Cc: stable@dpdk.org Suggested-by: Bruce Richardson Signed-off-by: Ferruh Yigit --- v2: * set 'build' if provided argument is testpmd path --- devtools/test-null.sh | 2 ++ mk/rte.app.mk | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/devtools/test-null.sh b/devtools/test-null.sh index 9f9a459f7..afcd8bb29 100755 --- a/devtools/test-null.sh +++ b/devtools/test-null.sh @@ -11,6 +11,7 @@ coremask=${2:-3} # default using cores 0 and 1 eal_options=$3 testpmd_options=$4 +[ -f "$testpmd" ] && build=$(dirname $(dirname $testpmd)) [ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd [ -f "$testpmd" ] || testpmd=$build/app/testpmd if [ ! -f "$testpmd" ] ; then @@ -19,6 +20,7 @@ if [ ! -f "$testpmd" ] ; then fi if ldd $testpmd | grep -q librte_ ; then + export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH libs='-d librte_mempool_ring.so -d librte_pmd_null.so' else libs= diff --git a/mk/rte.app.mk b/mk/rte.app.mk index a278552c6..05ea034b9 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -379,10 +379,6 @@ filter-libs = \ LDLIBS := $(call filter-libs,$(LDLIBS)) -ifeq ($(RTE_DEVEL_BUILD)$(CONFIG_RTE_BUILD_SHARED_LIB),yy) -LDFLAGS += -rpath=$(RTE_SDK_BIN)/lib -endif - MAPFLAGS = -Map=$@.map --cref .PHONY: all -- 2.21.0