From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 973A4A04B6; Sun, 24 Nov 2019 18:50:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF1062C6A; Sun, 24 Nov 2019 18:50:26 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id E366E2952 for ; Sun, 24 Nov 2019 18:50:25 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id r18so5862106pgu.13 for ; Sun, 24 Nov 2019 09:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Jh8Jqp2G4dFFiTlkX9m9yXVCAGXUs+IbR7Dtka2av3k=; b=pyo/ems1YQ0rocwp7w6wSAeoAdyTqKc8Gum4+uneWwi+I44PwPwtQUi6tmtwVXtapk N2g2T2HcTI/+gSMPBJtQE7UjU7PJtXXP6ylJ5T8X2QW7bgbRX5I3xHLws7dRZVjs3uEB EMHdCIXi5KqCyVYqe7+kOsLVwsIRkDrwMTub8LQJi3MWHr5UicxxzpZxcqkMOZJ5qhUW /D1b7WxC5TE1hU5Eu9RixRidbYqAHuwXYRAasiDjTLeytxX7ZmMaMLFSpcrA6cjFzJBd fg8i44QK3gf3A25NfuIURmUQLJiq0s1Q23bXZXCr0KYcJbJLT1kYgPgc6UF3VD14MGBm R96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jh8Jqp2G4dFFiTlkX9m9yXVCAGXUs+IbR7Dtka2av3k=; b=f0sQxxne3qEyjh0E+sb/dovpu5IhzCAMWqZdJ/lC3r9/OcBG7xlZwR6eoTET4ggvCJ D2GktkWaet8FZmmUQMDFGseNGO+SWZkR2i6nzj6ZS917+tVuQFFwmN3jeU/r6ZpuWlbS Mmr02or3iqCkBAloGDqj0puIhmp3dtA76kv6tF0ZXEYB/WI3mo9lpJz9pJmmTauuH5Z/ KsjgDdwXR2KqjDqfpNjNRCWRay5wpM7ZqL+X0GS0EMq1730dJXeAq8IXGW0Kj46cV/XP j106BFyEJmlazBhMQJyOYKotE2ARFH2f3ujlj7ynkv3sRdz43DPU+loWghSF70RfTmyy sQYA== X-Gm-Message-State: APjAAAUsCFR9hJLOUlJsXSto4LM9jk+AKyyR8Heoz2MXvqX7qUs4AShW jWSyeY2OXrd/UAhSIUDYaeWoQg== X-Google-Smtp-Source: APXvYqzI6Wlg1YE7p0pS3VpQV8hB5BRtSTIwKGgOKVQMgWwrnKNhnOMHaCcpdpuOXECgM9/0588jVw== X-Received: by 2002:aa7:824d:: with SMTP id e13mr29756166pfn.35.1574617824794; Sun, 24 Nov 2019 09:50:24 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c9sm5234243pfb.114.2019.11.24.09.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Nov 2019 09:50:24 -0800 (PST) Date: Sun, 24 Nov 2019 09:50:16 -0800 From: Stephen Hemminger To: Shahaf Shuler Cc: "dev@dpdk.org" , Thomas Monjalon , "olivier.matz@6wind.com" Message-ID: <20191124095016.7a5fe320@hermes.lan> In-Reply-To: <20191124055336.129527-1-shahafs@mellanox.com> References: <20191121122810.147351-1-shahafs@mellanox.com> <20191124055336.129527-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] mbuf: extend pktmbuf pool private structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 24 Nov 2019 05:53:46 +0000 Shahaf Shuler wrote: > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index 35df1c4c38..8fa7f49645 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -49,7 +49,7 @@ rte_pktmbuf_pool_init(struct rte_mempool *mp, void *opaque_arg) > /* if no structure is provided, assume no mbuf private area */ > user_mbp_priv = opaque_arg; > if (user_mbp_priv == NULL) { > - default_mbp_priv.mbuf_priv_size = 0; > + memset(&default_mbp_priv, 0, sizeof(default_mbp_priv)); An alternative would be to use structure initialization. struct rte_pktmbuf_pool_private default_mbp_priv = { };