From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DACA5A04E0; Fri, 29 Nov 2019 12:43:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C6A79E4; Fri, 29 Nov 2019 12:43:38 +0100 (CET) Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id 7F47D235; Fri, 29 Nov 2019 12:43:37 +0100 (CET) Received: from 2606-a000-111b-43ee-0000-0000-0000-115f.inf6.spectrum.com ([2606:a000:111b:43ee::115f] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1iaegC-0004yl-N3; Fri, 29 Nov 2019 06:43:27 -0500 Date: Fri, 29 Nov 2019 06:43:19 -0500 From: Neil Horman To: David Marchand Cc: dev , Thomas Monjalon , Andrew Rybchenko , dpdk stable , Ray Kinsella , John McNamara , Marko Kovacevic , Qiming Yang , Wenzhuo Lu , Declan Doherty , Adrien Mazarguil , Ferruh Yigit , Cristian Dumitrescu Message-ID: <20191129114319.GA10923@hmswarspite.think-freely.org> References: <20191125161314.18804-1-david.marchand@redhat.com> <20191126142212.GC21200@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Score: -2.9 (--) X-Spam-Status: No Subject: Re: [dpdk-dev] [RFC PATCH] mark experimental variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote: > On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > > So far, we did not pay attention to direct access to variables but they > > > are part of the API/ABI too and should be clearly identified. > > > > > > Introduce a __rte_experimental_var tag and mark existing variables. > > > > > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: David Marchand > > > --- > > > Quick patch to try to catch experimental variables. > > > Not sure if we could use a single section, so please advise if there is > > > better to do about this. > > > > > I don't see any definition of __rte_experimental_var here, won't the > > preprocessor choke on this when you try to compile without that? > > Sorry, not getting your point. > If there is an issue, then it is the same as __rte_experimental. > No, there is no issue, I'm just blind. For some reason cscope wasn't finding the definition of __rte_experimental_var when I applied your patch for me. Its clear you have it below. Acked-by: Neil Horman > [snip] > > > > diff --git a/lib/librte_eal/common/include/rte_compat.h b/lib/librte_eal/common/include/rte_compat.h > > > index 3eb33784b..3fd05179f 100644 > > > --- a/lib/librte_eal/common/include/rte_compat.h > > > +++ b/lib/librte_eal/common/include/rte_compat.h > > > @@ -11,11 +11,16 @@ > > > #define __rte_experimental \ > > > __attribute__((deprecated("Symbol is not yet part of stable ABI"), \ > > > section(".text.experimental"))) > > > +#define __rte_experimental_var \ > > > +__attribute__((deprecated("Symbol is not yet part of stable ABI"), \ > > > +section(".data.experimental"))) > > > > > > #else > > > > > > #define __rte_experimental \ > > > __attribute__((section(".text.experimental"))) > > > +#define __rte_experimental_var \ > > > +__attribute__((section(".data.experimental"))) > > > > > > #endif > > > > > > -- > David Marchand > >