From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 588FFA04E0;
Fri, 29 Nov 2019 22:09:24 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3773D9E4;
Fri, 29 Nov 2019 22:09:23 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 678FC235
for <dev@dpdk.org>; Fri, 29 Nov 2019 22:09:21 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
29 Nov 2019 13:09:19 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,258,1571727600"; d="scan'208";a="203832617"
Received: from silpixa00399838.ir.intel.com (HELO
silpixa00399838.ger.corp.intel.com) ([10.237.222.120])
by orsmga008.jf.intel.com with ESMTP; 29 Nov 2019 13:09:17 -0800
From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: david.marchand@redhat.com, thomas@monjalon.net, bruce.richardson@intel.com,
ray.kinsella@intel.com, Kevin Laatz <kevin.laatz@intel.com>
Date: Fri, 29 Nov 2019 21:08:58 +0000
Message-Id: <20191129210905.1865-1-kevin.laatz@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20191129171024.56165-1-kevin.laatz@intel.com>
References: <20191129171024.56165-1-kevin.laatz@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v3 0/7] Add ABI compatibility checks to the meson
build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
With the recent changes made to stabilize ABI versioning in DPDK, it will
become increasingly important to check patches for ABI compatibility. We
propose adding the ABI compatibility checking to be done as part of the
build.
The advantages to adding the ABI compatibility checking to the build are
two-fold. Firstly, developers can easily check their patches to make sure
they don’t break the ABI without adding any extra steps. Secondly, it
makes the integration into existing CI seamless since there are no extra
scripts to make the CI run. The build will run as usual and if an
incompatibility is detected in the ABI, the build will fail and show the
incompatibility. As an added bonus, enabling the ABI compatibility checks
does not impact the build speed.
The proposed solution works as follows:
1. Generate the ABI dump of the baseline. This can be done with the new
script added in this RFC. This step will only need to be done when the
ABI version changes (so once a year) and can be added to master so it
exists by default. This step can be skipped if the dump files for the
baseline already exist.
2. Build with meson. If there is an ABI incompatibility, the build will
fail and print the incompatibility information.
The patches accompanying this RFC add the ABI dump file generating script,
the meson option required to enable/disable the checks, and the required
meson changes to run the compatibility checks during the build.
---
v2:
- Rebased on master for 19.11.
- Moved the experimental syms checks next to the abi checks. This also
removed the dependency on the experimental checks from the shared
build.
- General cleanup.
v3:
- Fixed typo in meson option name in buildtools/meson.build.
Bruce Richardson (2):
build: enable debug info by default in meson builds
build: use meson warning levels
Kevin Laatz (5):
devtools: add abi dump generation script
build: add meson option for abi related checks
build: add lib abi checks to meson
build: add drivers abi checks to meson
build: clean up experimental syms check
buildtools/meson.build | 4 ++++
config/meson.build | 40 +++++++++++++++++++++-------------------
devtools/gen-abi-dump.sh | 24 ++++++++++++++++++++++++
drivers/meson.build | 34 ++++++++++++++++++++++++----------
lib/meson.build | 34 ++++++++++++++++++++++++----------
meson.build | 9 ++++++++-
meson_options.txt | 2 ++
7 files changed, 107 insertions(+), 40 deletions(-)
create mode 100755 devtools/gen-abi-dump.sh
--
2.17.1