From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 546FEA04B5; Wed, 4 Dec 2019 17:08:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D9121BF74; Wed, 4 Dec 2019 17:08:39 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 621FD1BF71 for ; Wed, 4 Dec 2019 17:08:37 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id b1so81068pgq.10 for ; Wed, 04 Dec 2019 08:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cGxg0qEmoMEch9AVamjx4ycFLoP8U01U7O1mZYxVMg4=; b=LDg+rT+14WwHCqkLDRsPGdAt0b2UQkJid4LF88XKkcQXg+FLSsFrfz99hqS+f9yZJF OQ1GzhgPb8XSRIxtUFAmDV7WIoILCsHaHWtTnsuCXEssU8mTu7OHrv9ibenKANNoIkXD tPZgLuALT6UD8hmXhmeqh+MdQJv6Zg/GBom16UhoxC9qTwyigz5SVoRFtVb7g12XJdAl V8tFaEtmrNnFypUb6fxjfxm+0hA/9Plnnkpise3fBKnJNsx+llpUtUoaGtw+DGE3MpQf HFavTNoDqL7Vyoqfba+WiXSUhLlYJT8cO+WHYmBeTUehd+xh82kBriDrRnYmKJ4RMgBH O7qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cGxg0qEmoMEch9AVamjx4ycFLoP8U01U7O1mZYxVMg4=; b=ZJbDt+4zii6A1Qt79fq4pY5yI5qUL7vTD0kS3dP5koAYZfEJFR1LM2P7PCWKXp0PbW 77vdVm+gbgwQns64tWRdI7Er4H6oTBsQlCTsMboixhpdT7W2aV1elvG1cwjab+KR3NcV ErEUPGjrxZtLihI6jNNmD7xO6tlKDNrp3n/NweQfeYigPhiTS2ZlV2zg+VleluUbuCfu 6vTmURp5XVCyC2XZSe4KTb/6jKSu+SzSv8/uq2DcwHx28lFGJvzUuRc4Ggmc/MxWY3O3 hJPTkm9zSQ48wuBh0ngESPmT8nM7KkCdjT4jtVFI2ZhPIjaWkihCnI0S7S8BPS3k5b1f ihag== X-Gm-Message-State: APjAAAV8YKe3XHxelLASWQAgXjJaf1WiVOFHl5CZYXOv3xvh2k+0cjVJ XGw9VfDSEguC0UuHJeU+BgyCDg== X-Google-Smtp-Source: APXvYqwlGOYtbfYbVSEi2ILZbGDUcY1KFSUc7ctKSLi+YDrPr1PKlw540ITR4ur2nmc1TMJfDirXYg== X-Received: by 2002:a63:d306:: with SMTP id b6mr4181981pgg.195.1575475716305; Wed, 04 Dec 2019 08:08:36 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z26sm7875019pgu.80.2019.12.04.08.08.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 08:08:36 -0800 (PST) Date: Wed, 4 Dec 2019 08:08:27 -0800 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, arybchenko@solarflare.com, stable@dpdk.org Message-ID: <20191204080827.154a5271@hermes.lan> In-Reply-To: <20191204150002.4824-1-david.marchand@redhat.com> References: <20191204150002.4824-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix build error on RHEL 7.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 4 Dec 2019 16:00:02 +0100 David Marchand wrote: > Previous fix gives hiccups to gcc on RHEL 7.6: >=20 > =3D=3D Build lib/librte_eal/linux/eal > CC eal_interrupts.o > ...lib/librte_eal/linux/eal/eal_interrupts.c: In function > =E2=80=98eal_intr_thread_main=E2=80=99: > ...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing > initializer for field =E2=80=98events=E2=80=99 of =E2=80=98struct epoll= _event=E2=80=99 > [-Werror=3Dmissing-field-initializers] > struct epoll_event ev =3D { }; > ^ > In file included from ...lib/librte_eal/linux/eal/eal_interrupts.c:15:0: > /usr/include/sys/epoll.h:89:12: note: =E2=80=98events=E2=80=99 declared h= ere > uint32_t events; /* Epoll events */ > ^ > ...lib/librte_eal/linux/eal/eal_interrupts.c: At top level: > cc1: error: unrecognized command line option > "-Wno-address-of-packed-member" [-Werror] > cc1: all warnings being treated as errors >=20 > Fixes: e0ab8020ac2a ("eal/linux: fix uninitialized data valgrind warning") > Cc: stable@dpdk.org >=20 > Reported-by: Andrew Rybchenko > Signed-off-by: David Marchand > --- > lib/librte_eal/linux/eal/eal_interrupts.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/l= inux/eal/eal_interrupts.c > index 2cd537ba4..14ebb108c 100644 > --- a/lib/librte_eal/linux/eal/eal_interrupts.c > +++ b/lib/librte_eal/linux/eal/eal_interrupts.c > @@ -1045,8 +1045,6 @@ eal_intr_handle_interrupts(int pfd, unsigned totalf= ds) > static __attribute__((noreturn)) void * > eal_intr_thread_main(__rte_unused void *arg) > { > - struct epoll_event ev =3D { }; > - > /* host thread, never break out */ > for (;;) { > /* build up the epoll fd with all descriptors we are to > @@ -1078,8 +1076,11 @@ eal_intr_thread_main(__rte_unused void *arg) > rte_spinlock_lock(&intr_lock); > =20 > TAILQ_FOREACH(src, &intr_sources, next) { > + struct epoll_event ev; > + > if (src->callbacks.tqh_first =3D=3D NULL) > continue; /* skip those with no callbacks */ > + memset(&ev, 0, sizeof(ev)); > ev.events =3D EPOLLIN | EPOLLPRI | EPOLLRDHUP | EPOLLHUP; > ev.data.fd =3D src->intr_handle.fd; > =20 Never mind, memset does the same thing. Not a fan of missing field initializer warnings.