From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5497A04F1; Fri, 13 Dec 2019 17:34:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 44F1E1BFFB; Fri, 13 Dec 2019 17:34:31 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 994CF1BF7C for <dev@dpdk.org>; Fri, 13 Dec 2019 17:34:29 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id a33so68951pgm.5 for <dev@dpdk.org>; Fri, 13 Dec 2019 08:34:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tx5d4mBeFxLeyLSHcXCGfjff9NagiEDdxTDENRZneIQ=; b=O4y7tfbUPwFr3sfniXPt4ClyhcWV7bTNEDipV9JBR9Ipe/SeBoOb3XlLa82EuEg9eT 083k/pBJ0Jr9/592rDLxp4eShy65M6magTUMaSvPth7FiS07gkffEsmrBo+ZuyJxgvSR sjyFkWIG3NCfYzNXeHLauYDbSJ1XB79tbBjTlbXRnRFZizptSvOj/7K3rLz18Oglu4xW Leoygf0lLvPd1lmWJSZrem+fMrHLAI957DONMEA+ExcKhrJBI86qOmQ9lWLD0si383sl yUp8ruYjTJTYQk/q+qP+XChqP02Z6pNNp7SCptD89Yp26WRHeQlJ8TXETZGCzW1ajCGC OQ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tx5d4mBeFxLeyLSHcXCGfjff9NagiEDdxTDENRZneIQ=; b=qXgeWnkpEqp3GJEbBuSmj9DSO+1ZxZrWXhTOyg+67LxuXSI3+ONBvjZ2g4A0ONOrhh VgDijzZcI0W86Lu0Srz1K4JHQD+eOLGR8K454GGoVlSxliO+9cT0upX3FHPjZB+Cif0t eLpE0MDrJ0lJWrYiLlye4VyUnGyR7kUT2EXpPcjidRVCFn58KBemYMFg2CsEUleYjvkG jPHx+Fl/JoUrQrHnOoxqUtFBjb20ogO2LdRSogjQLF49nLn+OqeKG1D1zlRRxrj+p9fd mQ60TMbFneQnjz70gA/McpfyzDAOG7UcCdUp4CYHrwM7KLZmBzAslWWWZWcUMZVIfxLV rl4Q== X-Gm-Message-State: APjAAAXINx5RDqlLAOIx0RYtXCfnglYeJoMvJc1SFVD+8iWqKgnF9peh eFQWa2EhTXHaLgHbZ+vk5dQtoA== X-Google-Smtp-Source: APXvYqzYsG/p2Bpz8ijCoecL1R+X5+3KhPdVM4W9DYrLExHNNrPg7cFSOVqG4fS5gVgL380Gmym5aQ== X-Received: by 2002:a63:2355:: with SMTP id u21mr281647pgm.179.1576254868729; Fri, 13 Dec 2019 08:34:28 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o19sm12338973pjr.2.2019.12.13.08.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2019 08:34:28 -0800 (PST) Date: Fri, 13 Dec 2019 08:34:20 -0800 From: Stephen Hemminger <stephen@networkplumber.org> To: Michal Krawczyk <mk@semihalf.com> Cc: dev@dpdk.org, gtzalik@amazon.com, mw@semihalf.com, matua@amazon.com, mba@semihalf.com, igorch@amazon.com Message-ID: <20191213083420.31f2b7c8@hermes.lan> In-Reply-To: <20191213133216.23572-2-mk@semihalf.com> References: <20191213133216.23572-1-mk@semihalf.com> <20191213133216.23572-2-mk@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/ena: upgrade HAL for new HW features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, 13 Dec 2019 14:32:15 +0100 Michal Krawczyk <mk@semihalf.com> wrote: > This version of the HAL allows to use the latest HW features, like > rx offsets. > > Driver was adjusted to the new version to fix the build. > > Signed-off-by: Michal Krawczyk <mk@semihalf.com> > Signed-off-by: Maciej Bielski <mba@semihalf.com> You are mixing multiple changes into one patch. This makes it harder to review (find the real bits) and also harder for bisection. It makes sense to fix whitespace and related stuff in one patch if you are fixing one function and the nearby code already needed work. But please avoid larger scale change put together. In your patch I see: - remove unnecessary whitespace - drop unnecessary inline - add missing newline in log messages - check for NULL pointer If possible could you preserve the per-commit updates for base code, rather than one lump diff.