From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, olivier.matz@6wind.com, stable@dpdk.org,
Ali Alnubani <alialnu@mellanox.com>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] devtools: avoid config backup during test build setup
Date: Mon, 16 Dec 2019 16:40:11 +0000 [thread overview]
Message-ID: <20191216164011.GA445@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20191216162242.1898285-1-thomas@monjalon.net>
On Mon, Dec 16, 2019 at 05:22:42PM +0100, Thomas Monjalon wrote:
> The config options are updated with sed and the short inline option.
> In FreeBSD, the suffix argument of the inline option is mandatory.
> In order to avoid creating a backup file when using sed inline,
> the argument is set as an empty suffix.
>
> The short option '-i' does not expect '=' before the suffix argument,
> so it understands '=' as the file suffix.
> As a consequence, a backup file named '.config=' was created
> in the build directory.
>
> Removing the '=' sign while keeping an empty suffix
> avoids creating a backup file.
>
> Fixes: 4a4a20c4775b ("devtools: support FreeBSD")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
>
> Reported-by: Ali Alnubani <alialnu@mellanox.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>
> This patch does not work on FreeBSD.
> Does it mean the equal sign is required on FreeBSD?
> This is not what I see on the documentation:
> https://www.freebsd.org/cgi/man.cgi?query=sed&sektion=&n=1
>
> ---
It appears it is needed, which is why the "=" was added in the first place.
See commit: 4a4a20c4775b ("devtools: support FreeBSD"), by Olivier
Is having the backup file a big issue?
Regards,
/Bruce
next prev parent reply other threads:[~2019-12-16 16:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 16:22 Thomas Monjalon
2019-12-16 16:40 ` Bruce Richardson [this message]
2019-12-16 16:47 ` Thomas Monjalon
2019-12-16 16:59 ` Bruce Richardson
2019-12-16 17:45 ` Thomas Monjalon
2019-12-16 19:15 ` [dpdk-dev] [PATCH v2] devtools: remove config backup after " Thomas Monjalon
2020-05-24 22:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216164011.GA445@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=alialnu@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).